Skip to content

fix(search): strip GitHub qualifier injection from search filter input #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anshul23102 wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Open

fix(search): strip GitHub qualifier injection from search filter input #691

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/hooks/useGitHubData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,17 @@ export const useGitHubData = (
let q = `author:${username} is:${type}`;

if (filters.search) {
q += ` ${filters.search} in:title`;
// Strip GitHub search qualifiers (key:value pairs) from the free-text
// search term before appending it to the query string. Allowing raw
// qualifier injection lets a caller override repo:, author:, is:, and
// other operators already set by the hook, potentially leaking data
// from repositories outside the intended scope.
const sanitizedSearch = filters.search
.replace(/[a-zA-Z_-]+:[^\s]*/g, '')
.trim();
if (sanitizedSearch) {
q += ` ${sanitizedSearch} in:title`;
}
}

if (filters.repo) {
Expand Down
Loading