Skip to content

Backwards Compatibility with older Core Versions#2051

Open
J04n5mith wants to merge 2 commits intoGitTools:mainfrom
J04n5mith:fix/backwardsDotnetCompability
Open

Backwards Compatibility with older Core Versions#2051
J04n5mith wants to merge 2 commits intoGitTools:mainfrom
J04n5mith:fix/backwardsDotnetCompability

Conversation

@J04n5mith
Copy link
Copy Markdown

Deleted --roll-forward Major argument so it executes when not latest dotnet version is installed.

Deleted --roll-forward Major argument so it executes when not latest dotnet version is installed.
@arturcic
Copy link
Copy Markdown
Member

Deleted --roll-forward Major argument so it executes when not latest dotnet version is installed.

Could you explain the reasoning for this PR?

@J04n5mith
Copy link
Copy Markdown
Author

We have some pipelines and agents which still not having dotnet 10 installed and we have also pipelines which must run in dotnet 8 or dotnet 9 container (If we're installing dotnet 10, the build is somehow broken). Upgrading dotnet version is in some projects a bit of a hustle and bug fixes must procceed. So I thought why not allow it to run with not newest Major version installed.

@J04n5mith
Copy link
Copy Markdown
Author

I could rewrite it to an option and it is defaulting to --roll-foward Major

@arturcic
Copy link
Copy Markdown
Member

I could rewrite it to an option and it is defaulting to --roll-foward Major

As far as I remembered that flag allows you to run a specific tool with a newer version of sdk of the original sdk which was used to build the tool, is not accessible. Have you tried to run the tool when there is no NET10 sdk installed?

@J04n5mith
Copy link
Copy Markdown
Author

J04n5mith commented Apr 28, 2026

Have you tried to run the tool when there is no NET10 sdk installed?

Yes. Here a example where I ran in a dotnet 8.0 sdk container in an azure pipeline. Somehow it forced to run with latest included versionen (i.e. 10.0)

App: /__t/GitVersion.Tool/6.7.0/dotnet-gitversion
Architecture: x64
Framework: 'Microsoft.NETCore.App', version '10.0.0' (x64)
.NET location: /usr/share/dotnet

The following frameworks were found:
  8.0.26 at [/usr/share/dotnet/shared/Microsoft.NETCore.App]

Edit: md syntax correction...
Edit2: I ran it with sdk 10 container or an agent with sdk 10 installed and it worked flawlessly. Tbf a colleague stated it’s because of that

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants