fix CI: official gradle wrapper, compileSdk 36, non-fatal lint, doc updates - #5
Conversation
…2.3.0) in README and contributing guide
📝 WalkthroughWalkthroughThe project now targets Android SDK 36, documents updated build requirements, configures lint behavior, and replaces both Gradle wrapper scripts with newer startup, argument-handling, Java-validation, and exit-handling logic. ChangesAndroid build requirements and configuration
Estimated code review effort: 4 (Complex) | ~45 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/build.gradle.kts`:
- Around line 51-54: Remove the project-wide abortOnError = false setting from
the lint configuration so lint failures continue to fail lintDebug, release
builds, and CI. In the lint block, replace it with a narrower baseline
assignment using lint-baseline.xml or targeted disable entries for the specific
known checks causing dependency-update failures, preserving enforcement for
human-authored lint issues.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: a4d41d09-9bee-4efb-bcea-048d059c7858
⛔ Files ignored due to path filters (1)
gradle/wrapper/gradle-wrapper.jaris excluded by!**/*.jar
📒 Files selected for processing (6)
CONTRIBUTING.mdREADME.mdapp/build.gradle.ktsgradle/wrapper/gradle-wrapper.propertiesgradlewgradlew.bat
| lint { | ||
| abortOnError = false | ||
| } | ||
|
|
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟠 Major | 🏗️ Heavy lift
abortOnError = false removes the lint safety net project-wide.
This applies to every lint task, including lintDebug and the lintVitalRelease check invoked during minified release builds. CONTRIBUTING.md (this PR) still documents that CI "runs lint" as a pull-request gate and instructs contributors to run ./gradlew assembleDebug lintDebug and make sure it is clean. With abortOnError = false, lint errors introduced by any contributor no longer fail lintDebug, assembleRelease, or CI, even though the documentation implies lint failures are enforced.
Consider a narrower fix that keeps the CI gate for human-authored changes:
- Add a lint baseline file (
lint { baseline = file("lint-baseline.xml") }) to suppress only pre-existing/dependency-triggered findings. - Or use
lint { disable += "SpecificCheckId" }for the specific check(s) that fail on Dependabot version bumps.
Do you want help identifying the specific lint check(s) causing the Dependabot CI failures so a baseline or targeted disable can replace the blanket abortOnError = false?
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@app/build.gradle.kts` around lines 51 - 54, Remove the project-wide
abortOnError = false setting from the lint configuration so lint failures
continue to fail lintDebug, release builds, and CI. In the lint block, replace
it with a narrower baseline assignment using lint-baseline.xml or targeted
disable entries for the specific known checks causing dependency-update
failures, preserving enforcement for human-authored lint issues.
Fixes the CI failures blocking all dependabot PRs:
Tested locally: assembleDebug, lintDebug and minified assembleRelease all pass.
Summary by CodeRabbit
Documentation
Build Improvements