Update PKGBUILD#108
Conversation
|
@l3afyb0y is attempting to deploy a commit to the gnarusg's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughVersion update to PKGBUILD incrementing package version from 0.5.9 to 0.6.0. This change affects the installation path resolution and version substitution within the DKMS configuration file during package building. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates the Arch Linux AUR PKGBUILD metadata to reflect the current CLI version, aligning the DKMS install path and substituted version fields with the intended release.
Changes:
- Bumps
pkgverfrom0.5.9to0.6.0.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| pkgname=maccel-dkms | ||
| _pkgname="maccel" | ||
| pkgver=0.5.9 | ||
| pkgver=0.6.0 | ||
| pkgrel=1 |
There was a problem hiding this comment.
pkgver is being updated, but the source still pulls directly from the Git repo without being pinned to a tag/commit. That means the built contents can drift from the declared pkgver, making the package non-reproducible and potentially causing DKMS module version/path mismatches. Consider pinning source to #tag=v${pkgver} (or using a release tarball URL), or alternatively convert this into a -git package with a pkgver() function derived from git describe and an appropriate pkgname.
|
@l3afyb0y What was the issue you encountered? |
When pkgver is the same as the installed version, pacman will typically skip building/updating files to match the changes, and tends to use a cached build for re-installations. So while I technically had no errors, the installed files didn't get replaced until after pkgver got bumped. |
|
So what you already had version 5.9 installed and so it wouldn't update? And it should have updated because there was actually code in the main branch that you needed that wasn't captured your previous installation of 5.9? |
when you install from a PKGBUILD on Arch, using an AUR helper, or makepkg directly, pacman builds the latest version and subsequently caches the built .pkg.tar.zst and relies on the pkgver to alert that the code has changed. If the pkgver is identical to the currently installed programs version number (in this case, v0.5.9), then pacman skips rebuilding the package (even, from my understanding, when makepkg is used) and "upgrades" (reinstalls) using the previously cached .pkg.tar.zst and assumes that the code is unchanged. At no point does pacman do any sort of check on the diff between current install and the codebase being used to upgrade. Updates are explicitly triggered by a change in pkgver. I believe it's stated in the man page PACMAN(5): https://man.archlinux.org/man/PKGBUILD.5 |
Summary
I noticed the PKGBUILD seemed out of date with the current version, causing me to hit issues when updating. Figured it might save some trouble to just PR the updated file.
I also noticed that there seems to be plans to automate uploading to AUR that has yet to be done. In the meantime, if you want anyone to maintain a package on AUR until you've setup your automation I would be happy to help out with that, and add an account as a co-maintainer to allow upstream to eventually setup automation. As an Arch user, AUR packages are super convenient, plus I maintain a couple packages already so I'm familiar with it as well. Feel free to reach out if you want!
Changes
Summary by CodeRabbit
Chores