Open
Conversation
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new
goodBridgeEnabledfeature flag is configured inuseFeaturesEnabledbut not actually used for the sidebar entry or route visibility, so consider wiring it through (similar tomicroBridgeEnabled) to control when/goodbridgeis shown. - There is an
index.tsx~file added undersrc/pages/gd/GoodBridge/that looks like an editor backup and should probably be removed from the PR. - The
Good Bridgesidebar item currently reuses thebridgeEnabledcondition (!isMinipay || bridgeEnabled), which may be tied to the micro-bridge; consider using a distinct check aligned withgoodBridgeEnabledto avoid coupling the two features.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `goodBridgeEnabled` feature flag is configured in `useFeaturesEnabled` but not actually used for the sidebar entry or route visibility, so consider wiring it through (similar to `microBridgeEnabled`) to control when `/goodbridge` is shown.
- There is an `index.tsx~` file added under `src/pages/gd/GoodBridge/` that looks like an editor backup and should probably be removed from the PR.
- The `Good Bridge` sidebar item currently reuses the `bridgeEnabled` condition (`!isMinipay || bridgeEnabled`), which may be tied to the micro-bridge; consider using a distinct check aligned with `goodBridgeEnabled` to avoid coupling the two features.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Author
|
hi @L03TJ3 here's the new PR also here's my wallet address |
10 tasks
Collaborator
|
@Gutopro Send you some CELO. That should give you enough to bridge from Celo > Fuse or XDC |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
This PR integrates the MessagePassingBridge
About #628
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist:
Summary by Sourcery
Add a new Good Bridge page integrating the MessagePassingBridge flow and expose it in navigation with feature flag control across supported networks.
New Features:
Enhancements: