Skip to content

refactor: remove incorrect address assignment in Web3Wallet initialization#520

Open
blueogin wants to merge 2 commits intomasterfrom
fix/default-wallet-address
Open

refactor: remove incorrect address assignment in Web3Wallet initialization#520
blueogin wants to merge 2 commits intomasterfrom
fix/default-wallet-address

Conversation

@blueogin
Copy link
Copy Markdown
Collaborator

@blueogin blueogin commented Mar 30, 2026

Description

Remove incorrect default address assignment in web3Wallet initialization

About # (link your issue here)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • PR title matches follow: (Feature|Bug|Chore) Task Name
  • My code follows the style guidelines of this project
  • I have followed all the instructions described in the initial task (check Definitions of Done)
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added reference to a related issue in the repository
  • I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
  • I have added screenshots related to my pull request (for frontend tasks)
  • I have pasted a gif showing the feature.
  • @mentions of the person or team responsible for reviewing proposed changes

Summary by Sourcery

Bug Fixes:

  • Prevent Web3Wallet from automatically assigning its primary address to the first derived or KMS-provided address during initialization, avoiding incorrect address state.

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Now that this.address is no longer set in the KMS and mnemonic paths, verify whether the class still needs a separate address property at all and either remove it entirely or make addresses[0] the single source of truth to avoid inconsistent state.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Now that `this.address` is no longer set in the KMS and mnemonic paths, verify whether the class still needs a separate `address` property at all and either remove it entirely or make `addresses[0]` the single source of truth to avoid inconsistent state.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants