refactor: remove incorrect address assignment in Web3Wallet initialization#520
Open
refactor: remove incorrect address assignment in Web3Wallet initialization#520
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Now that
this.addressis no longer set in the KMS and mnemonic paths, verify whether the class still needs a separateaddressproperty at all and either remove it entirely or makeaddresses[0]the single source of truth to avoid inconsistent state.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Now that `this.address` is no longer set in the KMS and mnemonic paths, verify whether the class still needs a separate `address` property at all and either remove it entirely or make `addresses[0]` the single source of truth to avoid inconsistent state.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
…ss after selection
L03TJ3
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove incorrect default address assignment in web3Wallet initialization
About # (link your issue here)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist:
Summary by Sourcery
Bug Fixes: