This repository was archived by the owner on Mar 14, 2024. It is now read-only.
Open
Conversation
|
✅ Preview (static) for commit 72c90af available at https://pr-7906-static-dot-dcc-staging.uc.r.appspot.com/. The following pages likely changed with this PR: |
JensenPaul
reviewed
Dec 4, 2023
| function generateBid(interestGroup) { | ||
| const { campaignId } = interestGroup.ads.metadata; | ||
| // Protected Audience API reporting worklet | ||
| function reportResult(auctionConfig, browserSignals, directFromSellerSignals) { |
There was a problem hiding this comment.
Probably better to use a buyer example as there's likely more buyers than sellers
Suggested change
| function reportResult(auctionConfig, browserSignals, directFromSellerSignals) { | |
| function reportWin(auctionSignals, perBuyerSignals, sellerSignals, browserSignals, directFromSellerSignals) { |
| const { campaignId } = interestGroup.ads.metadata; | ||
| // Protected Audience API reporting worklet | ||
| function reportResult(auctionConfig, browserSignals, directFromSellerSignals) { | ||
| const { topLevelSeller } = browserSignals; |
There was a problem hiding this comment.
let's simplify a bit
Suggested change
| const { topLevelSeller } = browserSignals; |
| registerAdBeacon({ | ||
| click: `https://your-server.example/report/click?campaignId=${campaignId}` | ||
| }) | ||
| click: `https://your-server.example/report/click?topLevelSeller=${topLevelSeller}` |
There was a problem hiding this comment.
Suggested change
| click: `https://your-server.example/report/click?topLevelSeller=${topLevelSeller}` | |
| click: `https://your-server.example/report/click?seller=${browserSignals.seller}` |
| click: `https://your-server.example/report/click?topLevelSeller=${topLevelSeller}` | ||
| }); | ||
|
|
||
| return signalsForWinner; |
There was a problem hiding this comment.
simplifies a bit if we're reportWin
Suggested change
| return signalsForWinner; |
Member
|
hi kevin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the example to use the
registerAdBeacon()call in a reporting worklet. The previous example usedgenerateBid()whereregisterAdBeacon()is not available.Preview: https://pr-7906-static-dot-dcc-staging.uc.r.appspot.com/docs/privacy-sandbox/protected-audience-api/reporting/#ads-reporting-api-for-fenced-frames-and-iframes