Skip to content

fix(kafka): resolve broker registration failure due to JLine warnings #1385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
diwakarrana-rana wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(kafka): resolve broker registration failure due to JLine warnings #1385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kafka/kafka.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ function wait_for_zookeeper() {
function wait_for_kafka() {
for i in {1..20}; do
local broker_list=$(get_broker_list || true)
if [[ "${broker_list}" == *" ${BROKER_ID},"* ]]; then
if echo "${broker_list}" | grep -q "${BROKER_ID}"; then
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The current grep command is too broad and can lead to false positives due to partial string matching. For instance, if BROKER_ID is 1, this check would incorrectly succeed if a broker with ID 10 is registered.

To ensure only the exact broker ID is matched, please use the -w flag with grep to perform a whole-word search. This will correctly identify the broker ID while ignoring partial matches.

Suggested change
if echo "${broker_list}" | grep -q "${BROKER_ID}"; then
if echo "${broker_list}" | grep -qw "${BROKER_ID}"; then

return 0
else
echo "Kafka broker ${BROKER_ID} is not registered yet, retry ${i}..."
Expand Down