chore(deps): update golangci/golangci-lint docker tag to v2.12.2#3385
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the update of the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
/gcbrun |
There was a problem hiding this comment.
Code Review
This pull request from Renovate updates the golangci-lint version. My review identifies a potential issue of version inconsistency. The update only targets one usage of the linter, but evidence from other files suggests there are multiple usages in the repository. I've left a comment on the change to highlight this problem, as using different linter versions can lead to inconsistent code quality checks.
| @@ -1,5 +1,5 @@ | |||
| SHELL := /bin/bash | |||
| GOLANGCI_VERSION := 2.8.0 | |||
| GOLANGCI_VERSION := 2.10.1 | |||
There was a problem hiding this comment.
This update appears to be incomplete, creating a version inconsistency for golangci-lint in the repository. While this line updates the version for blueprint tests, the file infra/build/developer-tools-krm/build/install_golangci_lint.sh indicates another usage of the linter. Having multiple versions of golangci-lint can lead to inconsistent linting results. To maintain consistency, all usages of golangci-lint across the repository should be updated to the same version.
8efb63a to
f759b2c
Compare
|
/gcbrun |
f759b2c to
90c95c8
Compare
|
/gcbrun |
90c95c8 to
00de76a
Compare
|
/gcbrun |
00de76a to
11f08d8
Compare
|
/gcbrun |
11f08d8 to
bef39f7
Compare
|
/gcbrun |
bef39f7 to
28795b2
Compare
|
/gcbrun |
28795b2 to
78f7e85
Compare
|
/gcbrun |
78f7e85 to
222a9b1
Compare
|
/gcbrun |
222a9b1 to
743ae91
Compare
|
/gcbrun |
743ae91 to
7f524d4
Compare
|
/gcbrun |
5cc24bf to
7058ebf
Compare
|
/gcbrun |
7058ebf to
3f5a3e2
Compare
|
/gcbrun |
3f5a3e2 to
39865b6
Compare
|
/gcbrun |
39865b6 to
31c72c6
Compare
|
/gcbrun |
31c72c6 to
3c56f7e
Compare
|
/gcbrun |
3c56f7e to
4084281
Compare
|
/gcbrun |
4084281 to
1ea94db
Compare
|
/gcbrun |
1ea94db to
fe8143c
Compare
|
/gcbrun |
Head branch was pushed to by a user without write access
fe8143c to
4a3aeaf
Compare
|
/gcbrun |
4a3aeaf to
3bd28ad
Compare
|
/gcbrun |
3bd28ad to
391e6e7
Compare
|
/gcbrun |
391e6e7 to
82d5b87
Compare
|
/gcbrun |
This PR contains the following updates:
2.8.0→2.12.2Release Notes
golangci/golangci-lint (golangci/golangci-lint)
v2.12.2Compare Source
Released on 2026-05-06
gomodguard_v2: fix blocked configurationgomodguard_v2: from 2.1.0 to 2.1.3iface: from 1.4.1 to 1.4.2v2.12.1Compare Source
Released on 2026-05-01
gomodguard_v2: fix panic with migration suggestioninstall.shscript (if you are still using an URL based on the branchmaster, please update to usehttps://golangci-lint.run/install.sh)v2.12.0Compare Source
Released on 2026-05-01
clickhouselintlinter https://github.com/ClickHouse/clickhouse-go-linterdupl: fromf665c8dtoc99c5cf(extended detection)funcorder: from 0.5.0 to 0.6.0 (new option:function)goconst: add an option to ignore strings from testsgoconst: from 1.8.2 to 1.10.0 (extended detection)gomodguard_v2: from 1.4.1 to 2.1.0 (major version with new configuration)gosec: from619ce21to 2.26.1 (new checks:G124,G708,G709,G710)govet: addinlineanalyzermakezero: from 2.1.0 to 2.2.1 (support slice type aliases)paralleltest: exposecheckcleanupoptionsloglint: from 0.11.1 to 0.12.0 (new options:allowed-keys,custom-funcs)wsl_v5: from 5.6.0 to 5.8.0 (new option:cuddle-max-statements; new checks:after-decl,after-defer,after-expr,after-go,cuddle-group)forbidigo: from 2.3.0 to 2.3.1godot: from 1.5.4 to 1.5.6govet-modernize: from 0.43.0 to 0.44.0ireturn: from 0.4.0 to 0.4.1rowserrcheck: from 1.1.1 toc5f79b8customcommandv2.11.4Compare Source
Released on 2026-03-22
govet-modernize: from 0.42.0 to 0.43.0noctx: from 0.5.0 to 0.5.1sqlclosecheck: from 0.5.1 to 0.6.0v2.11.3Compare Source
Released on 2026-03-10
gosec: from v2.24.7 to619ce21v2.11.2Compare Source
Released on 2026-03-07
fmt: fix error when using thefmtcommand with explicit paths.v2.11.1Compare Source
Released on 2026-03-06
Due to an error related to AUR, some artifacts of the v2.11.0 release have not been published.
This release contains the same things as v2.11.0.
v2.11.0Compare Source
Released on 2026-03-06
errcheck: from 1.9.0 to 1.10.0 (excludecrypto/rand.Readby default)gosec: from 2.23.0 to 2.24.6 (new rules:G113,G118,G119,G120,G121,G122,G123,G408,G707)noctx: from 0.4.0 to 0.5.0 (new detection:httptest.NewRequestWithContext)prealloc: from 1.0.2 to 1.1.0revive: from 1.14.0 to 1.15.0 (var-namingto a new rulepackage-naming)gocognit: from 1.2.0 to 1.2.1gosec: from 2.24.6 to 2.24.7unqueryvet: from 1.5.3 to 1.5.4v2.10.1Compare Source
Released on 2026-02-17
v2.10.0Compare Source
Released on 2026-02-17
ginkgolinter: from 0.22.0 to 0.23.0gosec: from 2.22.11 to 2.23.0 (new rules:G117,G602,G701,G702,G703,G704,G705,G706)staticcheck: from 0.6.1 to 0.7.0godoclint: from 0.11.1 to 0.11.2v2.9.0Compare Source
Released on 2026-02-10
arangolint: from 0.3.1 to 0.4.0 (new rule: detect potential query injections)ginkgolinter: from 0.21.2 to 0.22.0 (support for wrappers)golines: from 0.14.0 to 0.15.0misspell: from 0.7.0 to 0.8.0revive: from v1.13.0 to v1.14.0 (new rules:epoch-naming,use-slices-sort)unqueryvet: from 1.4.0 to 1.5.3 (new options:check-n1,check-sql-injection,check-tx-leaks,allow,custom-rules)wsl_v5: from 5.3.0 to 5.6.0 (new rule:after-block)modernize: from 0.41.0 to 0.42.0prealloc: from 1.0.1 to 1.0.2protogetter: from 0.3.18 to 0.3.20Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.