Fix evalbench core robustness#248
Open
aseering wants to merge 11 commits intoGoogleCloudPlatform:mainfrom
Open
Fix evalbench core robustness#248aseering wants to merge 11 commits intoGoogleCloudPlatform:mainfrom
aseering wants to merge 11 commits intoGoogleCloudPlatform:mainfrom
Conversation
Contributor
aseering
commented
Feb 21, 2026
aseering
commented
- evalbench.py: Support dict-based dataset_config extraction.
- postgres.py, mysql.py: Update to support local databases
- postgres.py: Enable UNIX domain socket connections for local auth.
- oneshotorchestrator.py: Add database name mapping/overrides for multi-engine evaluations.
- analyzer.py: Fix KeyError and ZeroDivisionError during reporting.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
aseering
force-pushed
the
fix-evalbench-core-robustness
branch
from
5b65c62 to
0e2bf12
Compare
Collaborator
|
/gcbrun |
IsmailMehdi
previously approved these changes
Feb 21, 2026
aseering
force-pushed
the
fix-evalbench-core-robustness
branch
from
227d134 to
a6c26ab
Compare
Contributor
Author
|
Oops -- I believe I've now removed the extra commits |
Collaborator
|
/gcbrun |
- evalbench.py: Support dict-based dataset_config extraction. - postgres.py: Enable UNIX domain socket connections for local auth. - oneshotorchestrator.py: Add database name mapping/overrides for multi-engine evaluations. - analyzer.py: Fix KeyError and ZeroDivisionError during reporting.
- databases/__init__.py: Register SpannerDB and MongoDB in factory. - mysql.py: Improve connection pooling and Cloud SQL handling. - sqlite.py: Implement copy-on-write for temporary databases to support file-based datasets.
- databases/__init__.py: Register SpannerDB and MongoDB in factory. - mysql.py: Improve connection pooling and Cloud SQL handling. - sqlite.py: Implement copy-on-write for temporary databases to support file-based datasets.
aseering
force-pushed
the
fix-evalbench-core-robustness
branch
from
5448356 to
a81d1d5
Compare
IsmailMehdi
reviewed
Mar 9, 2026
- Updated `evalbench/test/mongodb_test.py` to match the expected data format for `insert_data`. - Fixed `batch_execute` in `evalbench/databases/spanner.py` to correctly use `self.database.update_ddl` instead of just executing standard queries, as Spanner snapshots do not support DDL commands. - Updated `evalbench/test/spanner_test.py` to use `batch_execute` for DDL statements (CREATE TABLE, DROP TABLE). - Modified `.pycodestyle` to ignore `W504` (line break after binary operator), which conflicts with `W503` (line break before binary operator).
aseering
force-pushed
the
fix-evalbench-core-robustness
branch
from
5ff04a8 to
f21a310
Compare
aseering
commented
Mar 9, 2026
aseering
force-pushed
the
fix-evalbench-core-robustness
branch
from
b54e758 to
4b2682b
Compare
- Used autopep8 and sed to clean up all W291 and W293 errors in the python source.
aseering
force-pushed
the
fix-evalbench-core-robustness
branch
from
4b2682b to
3121072
Compare
Collaborator
|
/gcbrun |
Collaborator
|
/gcbrun |
Collaborator
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.