Skip to content

Ran migration tool with --skip-open-prs#17739

Draft
trodge wants to merge 3 commits into
GoogleCloudPlatform:mainfrom
trodge:yaml-migration
Draft

Ran migration tool with --skip-open-prs#17739
trodge wants to merge 3 commits into
GoogleCloudPlatform:mainfrom
trodge:yaml-migration

Conversation

@trodge
Copy link
Copy Markdown
Contributor

@trodge trodge commented May 26, 2026

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 26, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 54b53b3:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 22 files changed, 10 insertions(+), 37 deletions(-)
google-beta provider View Diff 23 files changed, 10 insertions(+), 38 deletions(-)
terraform-google-conversion View Diff 1 file changed, 3 deletions(-)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_feed (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_feed" "primary" {
  details {
    fox_it_stix_settings {
      ssl {
        encoded_private_key = # value needed
      }
    }
  }
}

Test report

Analytics

Total Tests Passed Skipped Affected
209 172 31 6
Affected Service Packages
  • binaryauthorization
  • chronicle
  • iambeta
  • iap

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccIapAppEngineVersionIamBindingGenerated
  • TestAccIapAppEngineVersionIamBindingGenerated_withCondition
  • TestAccIapAppEngineVersionIamMemberGenerated
  • TestAccIapAppEngineVersionIamMemberGenerated_withCondition
  • TestAccIapAppEngineVersionIamPolicyGenerated
  • TestAccIapAppEngineVersionIamPolicyGenerated_withCondition

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccIapAppEngineVersionIamBindingGenerated
❌ Error · Log - TestAccIapAppEngineVersionIamBindingGenerated_withCondition
❌ Error · Log - TestAccIapAppEngineVersionIamMemberGenerated
❌ Error · Log - TestAccIapAppEngineVersionIamMemberGenerated_withCondition
❌ Error · Log - TestAccIapAppEngineVersionIamPolicyGenerated
❌ Error · Log - TestAccIapAppEngineVersionIamPolicyGenerated_withCondition

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@trodge VCR tests complete for 54b53b3!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 26, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 3eab76c:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 22 files changed, 10 insertions(+), 37 deletions(-)
google-beta provider View Diff 23 files changed, 10 insertions(+), 38 deletions(-)
terraform-google-conversion View Diff 1 file changed, 3 deletions(-)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_feed (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_feed" "primary" {
  details {
    fox_it_stix_settings {
      ssl {
        encoded_private_key = # value needed
      }
    }
  }
}

Test report

Analytics

Total Tests Passed Skipped Affected
209 172 31 6
Affected Service Packages
  • binaryauthorization
  • chronicle
  • iambeta
  • iap

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccIapAppEngineVersionIamBindingGenerated
  • TestAccIapAppEngineVersionIamBindingGenerated_withCondition
  • TestAccIapAppEngineVersionIamMemberGenerated
  • TestAccIapAppEngineVersionIamMemberGenerated_withCondition
  • TestAccIapAppEngineVersionIamPolicyGenerated
  • TestAccIapAppEngineVersionIamPolicyGenerated_withCondition

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccIapAppEngineVersionIamBindingGenerated
❌ Error · Log - TestAccIapAppEngineVersionIamBindingGenerated_withCondition
❌ Error · Log - TestAccIapAppEngineVersionIamMemberGenerated
❌ Error · Log - TestAccIapAppEngineVersionIamMemberGenerated_withCondition
❌ Error · Log - TestAccIapAppEngineVersionIamPolicyGenerated
❌ Error · Log - TestAccIapAppEngineVersionIamPolicyGenerated_withCondition

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@trodge VCR tests complete for 3eab76c!

@trodge trodge force-pushed the yaml-migration branch 2 times, most recently from d069b89 to 4031693 Compare May 26, 2026 21:50
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 26, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d069b89:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 22 files changed, 10 insertions(+), 37 deletions(-)
google-beta provider View Diff 23 files changed, 10 insertions(+), 38 deletions(-)
terraform-google-conversion View Diff 1 file changed, 3 deletions(-)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_feed (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_feed" "primary" {
  details {
    fox_it_stix_settings {
      ssl {
        encoded_private_key = # value needed
      }
    }
  }
}

Test report

Analytics

Total Tests Passed Skipped Affected
209 172 31 6
Affected Service Packages
  • chronicle
  • iambeta
  • iap
  • binaryauthorization

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccIapAppEngineVersionIamBindingGenerated
  • TestAccIapAppEngineVersionIamBindingGenerated_withCondition
  • TestAccIapAppEngineVersionIamMemberGenerated
  • TestAccIapAppEngineVersionIamMemberGenerated_withCondition
  • TestAccIapAppEngineVersionIamPolicyGenerated
  • TestAccIapAppEngineVersionIamPolicyGenerated_withCondition

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccIapAppEngineVersionIamBindingGenerated
❌ Error · Log - TestAccIapAppEngineVersionIamBindingGenerated_withCondition
❌ Error · Log - TestAccIapAppEngineVersionIamMemberGenerated
❌ Error · Log - TestAccIapAppEngineVersionIamMemberGenerated_withCondition
❌ Error · Log - TestAccIapAppEngineVersionIamPolicyGenerated
❌ Error · Log - TestAccIapAppEngineVersionIamPolicyGenerated_withCondition

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@trodge VCR tests complete for d069b89!

@trodge trodge force-pushed the yaml-migration branch 2 times, most recently from ca58aed to c1bb46b Compare May 27, 2026 20:29
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 27, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c1bb46b:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 21 files changed, 27 deletions(-)
google-beta provider View Diff 22 files changed, 28 deletions(-)
terraform-google-conversion View Diff 1 file changed, 3 deletions(-)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_feed (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_feed" "primary" {
  details {
    fox_it_stix_settings {
      ssl {
        encoded_private_key = # value needed
      }
    }
  }
}

Test report

Analytics

Total Tests Passed Skipped Affected
88 85 3 0
Affected Service Packages
  • binaryauthorization
  • chronicle
  • iambeta

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@trodge VCR tests complete for c1bb46b!

@trodge trodge force-pushed the yaml-migration branch 2 times, most recently from 9b54fa3 to aa62829 Compare May 28, 2026 17:43
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 28, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 9b54fa3:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 20 files changed, 26 deletions(-)
google-beta provider View Diff 21 files changed, 27 deletions(-)
terraform-google-conversion View Diff 1 file changed, 3 deletions(-)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_feed (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_feed" "primary" {
  details {
    fox_it_stix_settings {
      ssl {
        encoded_private_key = # value needed
      }
    }
  }
}

Test report

Analytics

Total Tests Passed Skipped Affected
88 85 3 0
Affected Service Packages
  • iambeta
  • binaryauthorization
  • chronicle

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@trodge VCR tests complete for 9b54fa3!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 28, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit aa62829:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 20 files changed, 26 deletions(-)
google-beta provider View Diff 21 files changed, 27 deletions(-)
terraform-google-conversion View Diff 1 file changed, 3 deletions(-)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_feed (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_feed" "primary" {
  details {
    fox_it_stix_settings {
      ssl {
        encoded_private_key = # value needed
      }
    }
  }
}

Test report

Analytics

Total Tests Passed Skipped Affected
88 85 3 0
Affected Service Packages
  • binaryauthorization
  • chronicle
  • iambeta

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@trodge VCR tests complete for aa62829!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 28, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e4adc30:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 24 files changed, 18 insertions(+), 39 deletions(-)
google-beta provider View Diff 25 files changed, 18 insertions(+), 40 deletions(-)
terraform-google-conversion View Diff 1 file changed, 3 deletions(-)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_feed (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_feed" "primary" {
  details {
    fox_it_stix_settings {
      ssl {
        encoded_private_key = # value needed
      }
    }
  }
}

Test report

Analytics

Total Tests Passed Skipped Affected
175 168 3 4
Affected Service Packages
  • iambeta
  • binaryauthorization
  • chronicle
  • dataplex

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccDataplexDataProductDataAsset_dataplexDataProductDataAssetBasicExample
  • TestAccDataplexDataProductDataAsset_dataplexDataProductDataAssetFullExample
  • TestAccDataplexDataProduct_dataplexDataProductBasicExample
  • TestAccDataplexDataProduct_dataplexDataProductFullExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccDataplexDataProductDataAsset_dataplexDataProductDataAssetBasicExample
❌ Error · Log - TestAccDataplexDataProductDataAsset_dataplexDataProductDataAssetFullExample
❌ Error · Log - TestAccDataplexDataProduct_dataplexDataProductBasicExample
❌ Error · Log - TestAccDataplexDataProduct_dataplexDataProductFullExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@trodge VCR tests complete for e4adc30!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 28, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 75ba835:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 18 insertions(+), 13 deletions(-)
google-beta provider View Diff 4 files changed, 18 insertions(+), 13 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
87 83 0 4
Affected Service Packages
  • dataplex

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccDataplexDataProductDataAsset_dataplexDataProductDataAssetBasicExample
  • TestAccDataplexDataProductDataAsset_dataplexDataProductDataAssetFullExample
  • TestAccDataplexDataProduct_dataplexDataProductBasicExample
  • TestAccDataplexDataProduct_dataplexDataProductFullExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccDataplexDataProductDataAsset_dataplexDataProductDataAssetBasicExample
❌ Error · Log - TestAccDataplexDataProductDataAsset_dataplexDataProductDataAssetFullExample
❌ Error · Log - TestAccDataplexDataProduct_dataplexDataProductBasicExample
❌ Error · Log - TestAccDataplexDataProduct_dataplexDataProductFullExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@trodge VCR tests complete for 75ba835!

Copy link
Copy Markdown
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you start over and run the tool on a small number (<=10) of selected products (excluding EAP & products with whitespace issues), rather than the entire set? It would also be good to update the script to remove the old example template files if that's easy to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants