Skip to content

fix(#27128): fix for handling reservation_assignment id and name#17747

Open
sachinpro wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
sachinpro:fix_for_reservation_assignment
Open

fix(#27128): fix for handling reservation_assignment id and name#17747
sachinpro wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
sachinpro:fix_for_reservation_assignment

Conversation

@sachinpro
Copy link
Copy Markdown
Contributor

b/510064662

Fix plan diffs, ImportStateVerify, and CheckDestroy for BigQuery Reservation Assignment

  • Add post_read hook and symmetric diff suppression to 'google_bigquery_reservation_assignment' to normalize and suppress mismatches between reservation short names and canonical paths.
  • Harden test helper 'ReplaceVarsForTest' to identify self-links with a minimum of 3 slashes, preventing incorrect short-naming that caused 404 errors during CheckDestroy.
  • Add 'TestAccBigqueryReservationReservationAssignment_customSymmetricReservationDiffSuppress' to assert full lifecycle state verification without path ignores.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

bigquery: fixed BigQuery Reservation Assignment path normalization

@github-actions github-actions Bot requested a review from melinath May 27, 2026 15:59
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 27, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8ba21d1:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 138 insertions(+), 4 deletions(-)
google-beta provider View Diff 4 files changed, 138 insertions(+), 4 deletions(-)
terraform-google-conversion View Diff 1 file changed, 11 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
6470 5789 659 22
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 22 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccAccessContextManager__access_level_condition
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
  • TestAccBigqueryReservationReservationAssignment_bigqueryReservationAssignmentBasicExample
  • TestAccBigqueryReservationReservationAssignment_bigqueryReservationAssignmentFullExample
  • TestAccBigqueryReservationReservationAssignment_customSymmetricReservationDiffSuppress
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccContainerCluster_withLoggingConfig
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccEventarcTrigger_eventarcTriggerWithChannelCmekExample
  • TestAccEventarcTrigger_eventarcTriggerWithCloudRunDestinationExample
  • TestAccEventarcTrigger_eventarcTriggerWithHttpDestinationExample
  • TestAccEventarcTrigger_eventarcTriggerWithPathPatternFilterExample
  • TestAccEventarcTrigger_eventarcTriggerWithWorkflowDestinationExample
  • TestAccFirebaseWebApp_firebaseWebAppSkipDelete
  • TestAccHealthcareDicomStore_basic
  • TestAccHealthcareFhirStore_basic
  • TestAccHealthcareHl7V2Store_basic
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log - TestAccAccessContextManager/access_level
✅ Log - TestAccAccessContextManager/access_level_custom
✅ Log - TestAccAccessContextManager/access_level_full
✅ Log - TestAccAccessContextManager/access_levels
✅ Log - TestAccAccessContextManager/access_policy
✅ Log - TestAccAccessContextManager/authorized_orgs_desc
✅ Log - TestAccAccessContextManager/data_source_access_policy_basic
✅ Log - TestAccAccessContextManager/gcp_user_access_binding
✅ Log - TestAccAccessContextManager/service_perimeter
✅ Log - TestAccAccessContextManager/service_perimeter_dry_run_egress_policy
✅ Log - TestAccAccessContextManager/service_perimeter_dry_run_ingress_policy
✅ Log - TestAccAccessContextManager/service_perimeter_dry_run_resource
✅ Log - TestAccAccessContextManager/service_perimeter_egress_policy
✅ Log - TestAccAccessContextManager/service_perimeter_ingress_policy
✅ Log - TestAccAccessContextManager/service_perimeter_resource
✅ Log - TestAccAccessContextManager/service_perimeter_update
✅ Log - TestAccAccessContextManager/service_perimeters
✅ Log TestAccBigqueryReservationReservationAssignment_bigqueryReservationAssignmentBasicExample
✅ Log TestAccBigqueryReservationReservationAssignment_bigqueryReservationAssignmentFullExample
✅ Log TestAccEventarcTrigger_eventarcTriggerWithChannelCmekExample
✅ Log TestAccEventarcTrigger_eventarcTriggerWithCloudRunDestinationExample
✅ Log TestAccEventarcTrigger_eventarcTriggerWithHttpDestinationExample
✅ Log TestAccEventarcTrigger_eventarcTriggerWithPathPatternFilterExample
✅ Log TestAccEventarcTrigger_eventarcTriggerWithWorkflowDestinationExample
❌ Error · Log - TestAccAccessContextManager/access_level_condition
❌ Error · Log - TestAccAccessContextManager/access_policy_iam_binding
❌ Error · Log - TestAccAccessContextManager/access_policy_iam_member
❌ Error · Log - TestAccAccessContextManager/access_policy_iam_policy
❌ Error · Log - TestAccAccessContextManager/access_policy_scoped
❌ Error · Log - TestAccAccessContextManager/data_source_access_policy_scoped
❌ Error · Log - TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
❌ Error · Log - TestAccBigqueryReservationReservationAssignment_customSymmetricReservationDiffSuppress
❌ Error · Log - TestAccCloudRunService_cloudRunServiceGpuExample
❌ Error · Log - TestAccContainerCluster_withLoggingConfig
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log - TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccFirebaseWebApp_firebaseWebAppSkipDelete
❌ Error · Log - TestAccHealthcareDicomStore_basic
❌ Error · Log - TestAccHealthcareFhirStore_basic
❌ Error · Log - TestAccHealthcareHl7V2Store_basic
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@sachinpro, @melinath, @wj-chen VCR tests complete for 8ba21d1!

@modular-magician modular-magician requested a review from wj-chen May 27, 2026 16:08
@sachinpro sachinpro force-pushed the fix_for_reservation_assignment branch from 8ba21d1 to d2b11e7 Compare May 28, 2026 18:06
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 28, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d2b11e7:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 138 insertions(+), 4 deletions(-)
google-beta provider View Diff 4 files changed, 138 insertions(+), 4 deletions(-)
terraform-google-conversion View Diff 1 file changed, 11 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
6477 5796 664 17
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccAccessContextManager__access_level_condition
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
  • TestAccBigqueryReservationReservationAssignment_customSymmetricReservationDiffSuppress
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccContainerCluster_withLoggingConfig
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccFirebaseWebApp_firebaseWebAppSkipDelete
  • TestAccGKEHubFeatureMembership_gkehubFeatureMesh
  • TestAccHealthcareDicomStore_basic
  • TestAccHealthcareFhirStore_basic
  • TestAccHealthcareHl7V2Store_basic
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccProjectIamPolicy_invalidMembers
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log - TestAccAccessContextManager/access_level
✅ Log - TestAccAccessContextManager/access_level_custom
✅ Log - TestAccAccessContextManager/access_level_full
✅ Log - TestAccAccessContextManager/access_levels
✅ Log - TestAccAccessContextManager/access_policy
✅ Log - TestAccAccessContextManager/authorized_orgs_desc
✅ Log - TestAccAccessContextManager/data_source_access_policy_basic
✅ Log - TestAccAccessContextManager/gcp_user_access_binding
✅ Log - TestAccAccessContextManager/service_perimeter
✅ Log - TestAccAccessContextManager/service_perimeter_dry_run_egress_policy
✅ Log - TestAccAccessContextManager/service_perimeter_dry_run_ingress_policy
✅ Log - TestAccAccessContextManager/service_perimeter_dry_run_resource
✅ Log - TestAccAccessContextManager/service_perimeter_egress_policy
✅ Log - TestAccAccessContextManager/service_perimeter_ingress_policy
✅ Log - TestAccAccessContextManager/service_perimeter_resource
✅ Log - TestAccAccessContextManager/service_perimeter_update
✅ Log - TestAccAccessContextManager/service_perimeters
✅ Log TestAccBigqueryReservationReservationAssignment_customSymmetricReservationDiffSuppress
✅ Log TestAccProjectIamPolicy_invalidMembers
❌ Error · Log - TestAccAccessContextManager/access_level_condition
❌ Error · Log - TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
❌ Error · Log - TestAccCloudRunService_cloudRunServiceGpuExample
❌ Error · Log - TestAccContainerCluster_withLoggingConfig
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log - TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccFirebaseWebApp_firebaseWebAppSkipDelete
❌ Error · Log - TestAccGKEHubFeatureMembership_gkehubFeatureMesh
❌ Error · Log - TestAccHealthcareDicomStore_basic
❌ Error · Log - TestAccHealthcareFhirStore_basic
❌ Error · Log - TestAccHealthcareHl7V2Store_basic
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@sachinpro, @melinath, @wj-chen VCR tests complete for d2b11e7!

@sachinpro sachinpro force-pushed the fix_for_reservation_assignment branch from d2b11e7 to 730b74a Compare May 28, 2026 18:37
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 28, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 730b74a:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 138 insertions(+), 4 deletions(-)
google-beta provider View Diff 4 files changed, 138 insertions(+), 4 deletions(-)
terraform-google-conversion View Diff 1 file changed, 11 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
6477 5797 664 16
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 16 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccAccessContextManager__access_level_condition
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
  • TestAccBigqueryReservationReservationAssignment_customSymmetricReservationDiffSuppress
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccContainerCluster_withLoggingConfig
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccFirebaseWebApp_firebaseWebAppSkipDelete
  • TestAccHealthcareDicomStore_basic
  • TestAccHealthcareFhirStore_basic
  • TestAccHealthcareHl7V2Store_basic
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log - TestAccAccessContextManager/access_level
✅ Log - TestAccAccessContextManager/access_level_custom
✅ Log - TestAccAccessContextManager/access_level_full
✅ Log - TestAccAccessContextManager/access_levels
✅ Log - TestAccAccessContextManager/access_policy
✅ Log - TestAccAccessContextManager/authorized_orgs_desc
✅ Log - TestAccAccessContextManager/data_source_access_policy_basic
✅ Log - TestAccAccessContextManager/gcp_user_access_binding
✅ Log - TestAccAccessContextManager/service_perimeter
✅ Log - TestAccAccessContextManager/service_perimeter_dry_run_egress_policy
✅ Log - TestAccAccessContextManager/service_perimeter_dry_run_ingress_policy
✅ Log - TestAccAccessContextManager/service_perimeter_dry_run_resource
✅ Log - TestAccAccessContextManager/service_perimeter_egress_policy
✅ Log - TestAccAccessContextManager/service_perimeter_ingress_policy
✅ Log - TestAccAccessContextManager/service_perimeter_resource
✅ Log - TestAccAccessContextManager/service_perimeter_update
✅ Log - TestAccAccessContextManager/service_perimeters
✅ Log TestAccBigqueryReservationReservationAssignment_customSymmetricReservationDiffSuppress
✅ Log ❌ Error · Log TestAccProjectIamMemberRemove_memberInMultipleBindings
❌ Error · Log - TestAccAccessContextManager/access_level_condition
❌ Error · Log - TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
❌ Error · Log - TestAccCloudRunService_cloudRunServiceGpuExample
❌ Error · Log - TestAccContainerCluster_withLoggingConfig
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log - TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccFirebaseWebApp_firebaseWebAppSkipDelete
❌ Error · Log - TestAccHealthcareDicomStore_basic
❌ Error · Log - TestAccHealthcareFhirStore_basic
❌ Error · Log - TestAccHealthcareHl7V2Store_basic
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@sachinpro, @melinath, @wj-chen VCR tests complete for 730b74a!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants