feat(storagetransfer): add private_network_service to azure_blob_storage_data_source#17748
feat(storagetransfer): add private_network_service to azure_blob_storage_data_source#17748favoretti wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
ca9a9e8 to
e371cb3
Compare
…age_data_source Exposes the Service Directory Service endpoint used for transfers from a customer-managed VPC on AzureBlobStorageData, matching the API field already present in the SDK.
e371cb3 to
ea9e378
Compare
|
@SirGitsalot Could you have a look please? Thank you! |
Summary
Exposes the
privateNetworkServicefield onAzureBlobStorageDataingoogle_storage_transfer_job, enabling transfers from Azure Blob Storage over a customer-managed VPC via Service Directory. The field is already present in the SDK; the provider just wasn't surfacing it.Format:
projects/{projectId}/locations/{location}/namespaces/{namespace}/services/{service}.This is fully additive — the new attribute is
Optionalwith no default and no perma-diff. Backward compatible with all existing configurations.Note: the same
privateNetworkServicefield exists onAwsS3Data(separate from the existingmanaged_private_networkbool) and the provider also doesn't expose it there. Left out of this PR to keep it focused; happy to follow up if reviewers want them bundled.Test plan
TestAccStorageTransferJob_azureBlobStorageDataSourcePrivateNetworkawsS3CompatibleDataSourcetest)private_network_serviceround-trips through state on createprivate_network_serviceto a second Service Directory service to exercise mutabilityImportStateVerifyIgnoreonazure_credentialssince it's input-only per the API)Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.