Skip to content

feat(storagetransfer): add private_network_service to azure_blob_storage_data_source#17748

Open
favoretti wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
favoretti:add-azure-private-network-service
Open

feat(storagetransfer): add private_network_service to azure_blob_storage_data_source#17748
favoretti wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
favoretti:add-azure-private-network-service

Conversation

@favoretti
Copy link
Copy Markdown

@favoretti favoretti commented May 27, 2026

Summary

Exposes the privateNetworkService field on AzureBlobStorageData in google_storage_transfer_job, enabling transfers from Azure Blob Storage over a customer-managed VPC via Service Directory. The field is already present in the SDK; the provider just wasn't surfacing it.

Format: projects/{projectId}/locations/{location}/namespaces/{namespace}/services/{service}.

This is fully additive — the new attribute is Optional with no default and no perma-diff. Backward compatible with all existing configurations.

Note: the same privateNetworkService field exists on AwsS3Data (separate from the existing managed_private_network bool) and the provider also doesn't expose it there. Left out of this PR to keep it focused; happy to follow up if reviewers want them bundled.

Test plan

  • New acceptance test added: TestAccStorageTransferJob_azureBlobStorageDataSourcePrivateNetwork
    • Creates a real Service Directory namespace + two services so the references resolve API-side
    • Uses a placeholder Azure storage account / container / SAS token (the STS API accepts unvalidated source specs at create time, mirroring the existing awsS3CompatibleDataSource test)
    • Asserts private_network_service round-trips through state on create
    • Update step switches private_network_service to a second Service Directory service to exercise mutability
    • Each apply is followed by an import step (ImportStateVerifyIgnore on azure_credentials since it's input-only per the API)
  • Acceptance test execution pending — author does not have a test project with Azure / Service Directory set up for STS

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

storagetransfer: added `private_network_service` to resource `google_storage_transfer_job`

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label May 27, 2026
@google-cla
Copy link
Copy Markdown

google-cla Bot commented May 27, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions Bot requested a review from SirGitsalot May 27, 2026 17:55
@favoretti favoretti force-pushed the add-azure-private-network-service branch 2 times, most recently from ca9a9e8 to e371cb3 Compare May 27, 2026 18:10
…age_data_source

Exposes the Service Directory Service endpoint used for transfers from a
customer-managed VPC on AzureBlobStorageData, matching the API field
already present in the SDK.
@favoretti favoretti force-pushed the add-azure-private-network-service branch from e371cb3 to ea9e378 Compare May 27, 2026 18:14
@favoretti
Copy link
Copy Markdown
Author

@SirGitsalot Could you have a look please? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants