feat: add Terraform IAM support for BigQuery Routines#17754
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
77573fb to
8a99cce
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8a99cce: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @shubham643, @c2thorn, @wj-chen VCR tests complete for 8a99cce! |
8a99cce to
8fca19c
Compare
Description
This pull request adds first-class Terraform IAM support for BigQuery Routines (
google_bigquery_routine_iam_policy,google_bigquery_routine_iam_binding,google_bigquery_routine_iam_member).BigQuery Routines expose standard Resource Manager REST API methods (
POST /bigquery/v2/projects/*/datasets/*/routines/*:setIamPolicyand:getIamPolicy). Following the established pattern for BigQuery Tables, this change leverages MMv1's auto-generation engine by adding theiam_policyconfiguration block toRoutine.yaml, overriding the requested policy version to1to ensure backend API compatibility.Tracking Bug(s)
Design & API Documentation
Acceptance Tests
terraform applyagainst test projectspgindia-test-400206. Successfully established and verifiedgoogle_bigquery_routine_iam_binding.make testacc TEST=./google/services/bigquery TESTARGS="-run=TestAccBigqueryRoutineIam"). All E2E test steps (binding, member, policy) passed successfully.@GoogleCloudPlatform/terraform-autotest-contributors.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.