Add support for user-triggered rollouts#17756
Conversation
4a00b72 to
f57c9d0
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit f57c9d0: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_gke_hub_rollout_sequence" "primary" {
min_control_plane_version = # value needed
min_node_version = # value needed
}
Missing doc report (experimental)The following resources have fields missing in documents.
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @MikolajLuczko VCR tests complete for f57c9d0! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 565bd7c: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_gke_hub_rollout_sequence" "primary" {
min_control_plane_version = # value needed
min_node_version = # value needed
}
Missing doc report (experimental)The following resources have fields missing in documents.
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @MikolajLuczko VCR tests complete for 565bd7c! |
248eceb to
091c20c
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 091c20c: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_gke_hub_rollout_sequence" "primary" {
min_control_plane_version = # value needed
min_node_version = # value needed
}
Missing doc report (experimental)The following resources have fields missing in documents.
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @MikolajLuczko VCR tests complete for 091c20c! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8bb32ab: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_gke_hub_rollout_sequence" "primary" {
min_control_plane_version = # value needed
min_node_version = # value needed
}
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @MikolajLuczko VCR tests complete for 8bb32ab! |
Fixes hashicorp/terraform-provider-google#27578.
This PR introduces the following changes:
min_control_plane_versionandmin_node_versionoptional virtual fields, which allow the user to specify a GKE version for which a rollout should be created.target_control_plane_versionandtarget_node_versionoutput fields, which store information about the current target versions of the RolloutSequence, and allow us to make a decision on whether a rollout should be created in response to the user setting / updating themin_control_plane_versionandmin_node_versionfields (the rollout will be created only if the version specified by the user is strictly higher than the corresponding target version stored in the RolloutSequence).operational_stateoutput field, which stores information about the current state of the RolloutSequence (INITIALIZING,WARNING,ERROR).post_createandpost_updatehooks, which execute code if the user has set or updated either of the (min_control_plane_version,min_node_version) fields and call the UpgradeRolloutSequence endpoint to create a new rollout if necessary.post_create_failurehook, so that a RolloutSequence which encountered an error during its creation is immediately deleted instead of marked as "tainted" by Terraform.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.