identity: add values from import_format in identitySchema not in properties list#17759
identity: add values from import_format in identitySchema not in properties list#17759BBBmau wants to merge 2 commits into
identity: add values from import_format in identitySchema not in properties list#17759Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 41ff348: Diff reportYour PR generated the following diffs in downstream repositories:
Step 1: Replaying Mode Caution Panic occurred during VCR tests 🔴 REPLAYING mode: The provider crashed with a panic. Please check the build log for details. Please fix the issue to complete your PR. View the build log |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e5c8457: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 16 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. 🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. |
e5c8457 to
72cea86
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 72cea86: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. |
We run into a case in several resources such as dataset where a value within
import_formatis at times a value that is not included in properties list resulting in a value such asdataset_idnot being included in identity schema. PR resolves this by creating a new Type for the missing value in properties:also included a unit test that replicates this specific edge case
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.