Skip to content

identity: add values from import_format in identitySchema not in properties list#17759

Open
BBBmau wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
BBBmau:catch-identity-values-not-in-properties-list
Open

identity: add values from import_format in identitySchema not in properties list#17759
BBBmau wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
BBBmau:catch-identity-values-not-in-properties-list

Conversation

@BBBmau
Copy link
Copy Markdown
Collaborator

@BBBmau BBBmau commented May 28, 2026

We run into a case in several resources such as dataset where a value within import_format is at times a value that is not included in properties list resulting in a value such as dataset_id not being included in identity schema. PR resolves this by creating a new Type for the missing value in properties:

	for _, field := range importFormat {
		if includedValues[field] || field == "project" || field == "zone" || field == "region" {
			continue
		}
		props = append(props, &Type{Name: field, Type: "string", Required: true})
		includedValues[field] = true
	}

also included a unit test that replicates this specific edge case

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 28, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 41ff348:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 26 files changed, 229 insertions(+)
google-beta provider View Diff 26 files changed, 229 insertions(+)

Step 1: Replaying Mode

Caution

Panic occurred during VCR tests

🔴 REPLAYING mode: The provider crashed with a panic. Please check the build log for details.

Please fix the issue to complete your PR.

View the build log

@BBBmau, @shuyama1 VCR tests complete for 41ff348!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 28, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e5c8457:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 742 files changed, 10011 insertions(+), 5862 deletions(-)
google-beta provider View Diff 817 files changed, 11016 insertions(+), 6465 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
5772 5255 501 16
Affected Service Packages
  • cloudquotas
  • containerattached
  • essentialcontacts
  • healthcare
  • networkconnectivityv1
  • servicenetworking
  • bigquery
  • cloudasset
  • datacatalog
  • gkeonprem
  • resourcemanagerv3
  • apigee
  • cloudsecuritycompliance
  • edgenetwork
  • iamworkforcepool
  • networkconnectivity
  • biglake
  • deploymentmanager
  • monitoring
  • osconfigv2
  • securityposture
  • spanner
  • activedirectory
  • billingbudgets
  • cloudbuild
  • iam2
  • observability
  • alloydb
  • binaryauthorization
  • containeranalysis
  • datapipeline
  • iap
  • privilegedaccessmanager
  • storagecontrol
  • developerconnect
  • memorystore
  • firebaseappcheck
  • parametermanagerregional
  • privateca
  • securityscanner
  • storagebatchoperations
  • transcoder
  • bigquerydatapolicy
  • osconfig
  • securitycentermanagement
  • cloudbuildv2
  • cloudtasks
  • dialogflowcx
  • firebaseapphosting
  • saasruntime
  • vectorsearch
  • pubsub
  • siteverification
  • apihub
  • firebase
  • firebasestorage
  • kms
  • managedkafka
  • notebooks
  • contactcenterinsights
  • iam3
  • resourcemanager
  • secretmanagerregional
  • sql
  • accesscontextmanager
  • firebaseremoteconfig
  • ces
  • dataform
  • datastream
  • edgecontainer
  • looker
  • appengine
  • hypercomputecluster
  • lustre
  • networkservices
  • securesourcemanager
  • datalineage
  • biglakeiceberg
  • cloudrunv2
  • colab
  • dns
  • oslogin
  • parallelstore
  • vmwareengine
  • memcache
  • mlengine
  • bigqueryconnection
  • datafusion
  • netapp
  • secretmanager
  • workbench
  • cloudbilling
  • eventarc
  • filestore
  • firebaseailogic
  • firebasehosting
  • gkehub2
  • securitycenter
  • storageinsights
  • apphub
  • dataplex
  • redis
  • storagetransfer
  • tags
  • clouddeploy
  • documentai
  • firestore
  • integrationconnectors
  • vertexai
  • dialogflow
  • modelarmor
  • oracledatabase
  • clouddomains
  • cloudids
  • gkehub
  • modelarmorglobal
  • networksecurity
  • dataprocmetastore
  • gemini
  • iambeta
  • pubsublite
  • workflows
  • accessapproval
  • dataproc
  • gkebackup
  • storage
  • bigtable
  • discoveryengine
  • vpcaccess
  • apigateway
  • artifactregistry
  • beyondcorp
  • bigquerydatapolicyv2
  • cloudfunctions2
  • compute
  • databasemigrationservice
  • datalossprevention
  • cloudrun
  • firebasedatabase
  • firebasedataconnect
  • firebaseextensions
  • integrations
  • securitycenterv2
  • sourcerepo
  • tpuv2
  • backupdr
  • cloudidentity
  • composer
  • config
  • networkmanagement
  • orgpolicy
  • workstations
  • chronicle
  • bigquerydatatransfer
  • blockchainnodeengine
  • identityplatform
  • logging
  • certificatemanager
  • cloudscheduler
  • migrationcenter
  • parametermanager
  • bigqueryreservation
  • dataprocgdc
  • documentaiwarehouse
  • serviceusage
  • workloadidentity
  • bigqueryanalyticshub

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 16 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
  • TestAccBigQueryDataset_bigqueryDatasetAuthorizedDatasetExample
  • TestAccBigQueryDataset_bigqueryDatasetAuthorizedRoutineExample
  • TestAccBigQueryDataset_bigqueryDatasetBasicExample
  • TestAccBigQueryDataset_bigqueryDatasetCaseInsensitiveNamesExample
  • TestAccBigQueryDataset_bigqueryDatasetDefaultCollationSetExample
  • TestAccBigQueryDataset_bigqueryDatasetResourceTagsExample
  • TestAccBigQueryDataset_bigqueryDatasetWithMaxTimeTravelHoursExample
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccDataformConfig_update
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccBigQueryDataset_bigqueryDatasetAuthorizedDatasetExample
✅ Log TestAccBigQueryDataset_bigqueryDatasetAuthorizedRoutineExample
✅ Log TestAccBigQueryDataset_bigqueryDatasetBasicExample
✅ Log TestAccBigQueryDataset_bigqueryDatasetCaseInsensitiveNamesExample
✅ Log TestAccBigQueryDataset_bigqueryDatasetDefaultCollationSetExample
✅ Log TestAccBigQueryDataset_bigqueryDatasetResourceTagsExample
✅ Log TestAccBigQueryDataset_bigqueryDatasetWithMaxTimeTravelHoursExample
✅ Log ❌ Error · Log TestAccDataformConfig_update
✅ Log ❌ Error · Log TestAccProjectIamMemberRemove_memberInMultipleBindings
❌ Error · Log - TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
❌ Error · Log - TestAccCloudRunService_cloudRunServiceGpuExample
❌ Error · Log - TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@BBBmau, @shuyama1 VCR tests complete for e5c8457!

@BBBmau BBBmau force-pushed the catch-identity-values-not-in-properties-list branch from e5c8457 to 72cea86 Compare May 28, 2026 22:31
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 28, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 72cea86:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 15 files changed, 137 insertions(+)
google-beta provider View Diff 15 files changed, 137 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
152 135 10 7
Affected Service Packages
  • bigquery

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccBigQueryDataset_bigqueryDatasetAuthorizedDatasetExample
  • TestAccBigQueryDataset_bigqueryDatasetAuthorizedRoutineExample
  • TestAccBigQueryDataset_bigqueryDatasetBasicExample
  • TestAccBigQueryDataset_bigqueryDatasetCaseInsensitiveNamesExample
  • TestAccBigQueryDataset_bigqueryDatasetDefaultCollationSetExample
  • TestAccBigQueryDataset_bigqueryDatasetResourceTagsExample
  • TestAccBigQueryDataset_bigqueryDatasetWithMaxTimeTravelHoursExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccBigQueryDataset_bigqueryDatasetAuthorizedDatasetExample
✅ Log TestAccBigQueryDataset_bigqueryDatasetAuthorizedRoutineExample
✅ Log TestAccBigQueryDataset_bigqueryDatasetBasicExample
✅ Log TestAccBigQueryDataset_bigqueryDatasetCaseInsensitiveNamesExample
✅ Log TestAccBigQueryDataset_bigqueryDatasetDefaultCollationSetExample
✅ Log TestAccBigQueryDataset_bigqueryDatasetResourceTagsExample
✅ Log TestAccBigQueryDataset_bigqueryDatasetWithMaxTimeTravelHoursExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@BBBmau, @shuyama1 VCR tests complete for 72cea86!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants