Skip to content

Adding in google_memorystore_acl_policy and google_redis_acl_policy with coresponding datasources and acl_policy field on redis cluster and memorystore#18299

Open
NA2047 wants to merge 4 commits into
GoogleCloudPlatform:mainfrom
NA2047:aclPolicy
Open

Adding in google_memorystore_acl_policy and google_redis_acl_policy with coresponding datasources and acl_policy field on redis cluster and memorystore#18299
NA2047 wants to merge 4 commits into
GoogleCloudPlatform:mainfrom
NA2047:aclPolicy

Conversation

@NA2047

@NA2047 NA2047 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_memorystore_acl_policy`
`google_redis_acl_policy`
`google_redis_acl_policy`
`google_memorystore_acl_policy`

@NA2047
NA2047 marked this pull request as draft July 15, 2026 22:05
@github-actions
github-actions Bot requested a review from melinath July 15, 2026 22:05
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

modular-magician commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 0903531:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 24 files changed, 3009 insertions(+), 2 deletions(-)
google-beta provider View Diff 24 files changed, 3009 insertions(+), 2 deletions(-)
terraform-google-conversion View Diff 8 files changed, 377 insertions(+), 1 deletion(-)

Missing service labels

The following new resources do not have corresponding service labels:

  • google_redis_acl_policy

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Multiple resources added

This PR adds multiple new resources: google_memorystore_acl_policy, google_redis_acl_policy. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

  • memorystore
  • redis

Please fix the compilation errors to complete your PR.

View the build log

@NA2047, @melinath VCR tests complete for 0903531!

@modular-magician

modular-magician commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit fb04cf5:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 24 files changed, 3009 insertions(+), 2 deletions(-)
google-beta provider View Diff 24 files changed, 3009 insertions(+), 2 deletions(-)
terraform-google-conversion View Diff 8 files changed, 377 insertions(+), 1 deletion(-)

Missing service labels

The following new resources do not have corresponding service labels:

  • google_redis_acl_policy

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Multiple resources added

This PR adds multiple new resources: google_memorystore_acl_policy, google_redis_acl_policy. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

  • memorystore
  • redis

Please fix the compilation errors to complete your PR.

View the build log

@NA2047, @melinath VCR tests complete for fb04cf5!

@modular-magician

modular-magician commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit bae5edd:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 24 files changed, 3009 insertions(+), 2 deletions(-)
google-beta provider View Diff 24 files changed, 3009 insertions(+), 2 deletions(-)
terraform-google-conversion View Diff 8 files changed, 377 insertions(+), 1 deletion(-)

Missing service labels

The following new resources do not have corresponding service labels:

  • google_redis_acl_policy

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Multiple resources added

This PR adds multiple new resources: google_memorystore_acl_policy, google_redis_acl_policy. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

  • memorystore
  • redis

Please fix the compilation errors to complete your PR.

View the build log

@NA2047, @melinath VCR tests complete for bae5edd!

@modular-magician

modular-magician commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 9eb2139:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 24 files changed, 3007 insertions(+)
google-beta provider View Diff 24 files changed, 3007 insertions(+)
terraform-google-conversion View Diff 8 files changed, 377 insertions(+), 1 deletion(-)

Missing service labels

The following new resources do not have corresponding service labels:

  • google_redis_acl_policy

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Multiple resources added

This PR adds multiple new resources: google_memorystore_acl_policy, google_redis_acl_policy. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

  • memorystore
  • redis

Please fix the compilation errors to complete your PR.

View the build log

@NA2047, @melinath VCR tests complete for 9eb2139!

@modular-magician

modular-magician commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5925778:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 24 files changed, 3007 insertions(+)
google-beta provider View Diff 24 files changed, 3007 insertions(+)
terraform-google-conversion View Diff 8 files changed, 377 insertions(+), 1 deletion(-)

Missing service labels

The following new resources do not have corresponding service labels:

  • google_redis_acl_policy

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Multiple resources added

This PR adds multiple new resources: google_memorystore_acl_policy, google_redis_acl_policy. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

  • memorystore
  • redis

Please fix the compilation errors to complete your PR.

View the build log

@NA2047, @melinath VCR tests complete for 5925778!

@modular-magician

modular-magician commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 3053296:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 24 files changed, 3006 insertions(+)
google-beta provider View Diff 24 files changed, 3006 insertions(+)
terraform-google-conversion View Diff 8 files changed, 377 insertions(+), 1 deletion(-)

Missing service labels

The following new resources do not have corresponding service labels:

  • google_redis_acl_policy

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Multiple resources added

This PR adds multiple new resources: google_memorystore_acl_policy, google_redis_acl_policy. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

  • memorystore

Please fix the compilation errors to complete your PR.

View the build log

@NA2047, @melinath VCR tests complete for 3053296!

@modular-magician

modular-magician commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e1c682c:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 24 files changed, 3005 insertions(+)
google-beta provider View Diff 24 files changed, 3005 insertions(+)
terraform-google-conversion View Diff 8 files changed, 377 insertions(+), 1 deletion(-)

Missing service labels

The following new resources do not have corresponding service labels:

  • google_redis_acl_policy

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Multiple resources added

This PR adds multiple new resources: google_memorystore_acl_policy, google_redis_acl_policy. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
73 65 0 8
Affected Service Packages
  • memorystore
  • redis

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccMemorystoreAclPolicyDatasource
  • TestAccMemorystoreAclPolicy_basic
  • TestAccMemorystoreAclPolicy_withInstance
  • TestAccMemorystoreInstance_withAclPolicy
  • TestAccRedisAclPolicyDatasource
  • TestAccRedisAclPolicy_basic
  • TestAccRedisAclPolicy_withCluster
  • TestAccRedisCluster_withAclPolicy

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccMemorystoreAclPolicyDatasource
✅ Log TestAccMemorystoreAclPolicy_basic
✅ Log TestAccMemorystoreAclPolicy_withInstance
✅ Log TestAccMemorystoreInstance_withAclPolicy
✅ Log TestAccRedisAclPolicyDatasource
✅ Log TestAccRedisAclPolicy_basic
✅ Log TestAccRedisAclPolicy_withCluster
✅ Log TestAccRedisCluster_withAclPolicy

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@NA2047, @melinath VCR tests complete for e1c682c!

@NA2047
NA2047 marked this pull request as ready for review July 16, 2026 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants