Added missing fields to google_colab_schedule and marked google_vertex_ai_schedule as deprecated#18303
Added missing fields to google_colab_schedule and marked google_vertex_ai_schedule as deprecated#18303melinath wants to merge 17 commits into
Conversation
…x_ai_schedule as deprecated
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
/gcbrun |
This comment was marked as outdated.
This comment was marked as outdated.
…r create_notebook_execution_job_request
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Reservations are difficult to create and manage in tests
…orted for create_notebook_execution_job_request" This reverts commit a2c147e.
This comment was marked as outdated.
This comment was marked as outdated.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8c108bd: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_colab_schedule" "primary" {
create_notebook_execution_job_request {
notebook_execution_job {
custom_environment_spec {
machine_spec {
reservation_affinity {
key = # value needed
reservation_affinity_type = # value needed
use_reservation_pool = # value needed
values = # value needed
}
}
}
}
}
}
Test reportImportant Manual Verification Required (GA-only additions) The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually: 🔴 TestAccColabSchedule_colabScheduleFullExample Analytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details. 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. |
Interesting design notes:
artifactIdfield pointing to an artifact resource - see https://docs.cloud.google.com/gemini-enterprise-agent-platform/reference/rest/v1/projects.locations.pipelineJobs#PipelineJob.RuntimeConfig. (Note: the artifact resource also isn't supported in Terraform so we'd need to add support for that first.)pipeline_job_idoutput-only on Colab schedule - trying to create a resource with it set caused the error:create_pipeline_job_request.pipeline_job_id should not be set. I looked into it and it looks like this isn't settable on scheduled jobs, only directly created jobs.create_notebook_execution_job_request.notebook_execution_job_idRelease Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.