Add allowRequesterSpecifiedNotBeforeTime to CaPool and requestedNotBeforeTime to Certificate#18310
Conversation
…foreTime to Certificate This commit adds support for two new fields in the privateca product: 1. `allow_requester_specified_not_before_time` in `google_privateca_ca_pool` 2. `requested_not_before_time` in `google_privateca_certificate` A single-step acceptance test is included, using `depends_on` to ensure the timestamp is captured after CA creation.
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5ce61c4: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @nat-hill, @SirGitsalot VCR tests complete for 5ce61c4! |
… to dynamic timestamp
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 31ff088: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportImportant Manual Verification Required VCR cannot automatically execute the following tests added in this PR. Please verify them manually: 🔴 TestAccPrivatecaCertificate_privatecaCertificateWithRequestedNotBeforeTimeExample Analytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. Caution Issues requiring attention before PR completion 🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the replaying VCR build log @nat-hill, @SirGitsalot VCR tests complete for 31ff088! |
Description
This PR adds support for two new flags related to certificate backdating in the Private CA product:
allow_requester_specified_not_before_timeingoogle_privateca_ca_pool: Allows configuring a CA pool to permit requesters to specify thenot_before_timein certificate requests.requested_not_before_timeingoogle_privateca_certificate: Allows specifying a customnot_before_timewhen requesting a certificate (requires the pool to haveallow_requester_specified_not_before_timeenabled).Key Changes
CaPool.yamlandCertificate.yaml.privateca_certificate_with_requested_not_before_time).time_staticresource with adepends_onblock in the test config to ensure the timestamp is dynamically set after the Certificate Authority is created, satisfying the API CA not_before_time restriction.privateca_certificate_509_config.go.tmplandprivateca_certificate_template_509_config.go.tmpl) where they returned an empty map instead of nil when input was nil, which was blocking my test.📋 Checklist
make testandmake lintin the generated providers to ensure it passes unit and linter tests.🚀 Release Note Template for Downstream PRs