Skip to content

Adding TelemetryPolicy#18315

Draft
pawelJas wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
pawelJas:network_services_telemetry_policy
Draft

Adding TelemetryPolicy#18315
pawelJas wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
pawelJas:network_services_telemetry_policy

Conversation

@pawelJas

Copy link
Copy Markdown
Contributor

Adds TelemetryPolicy resources to NetworkServices API.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_network_services_telemetry_policy`

@modular-magician

modular-magician commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a86694e:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 1830 insertions(+)
google-beta provider View Diff 5 files changed, 1830 insertions(+)
terraform-google-conversion View Diff 1 file changed, 358 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 114 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_services_telemetry_policy (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_services_telemetry_policy" "primary" {
  display_name = # value needed
  metrics_configuration {
    enabled  = # value needed
    metadata = # value needed
  }
  tracing_configuration {
    custom_span_attributes {
      attribute_name    = # value needed
      from_header_value = # value needed
      literal_value     = # value needed
    }
    parent_based_sampling {
      enabled       = # value needed
      sampling_rate = # value needed
    }
    sampling_rate = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_network_services_telemetry_policy

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
102 99 2 1
Affected Service Packages
  • networkservices

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccNetworkServicesTelemetryPolicy_networkServicesTelemetryPolicyBasicExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccNetworkServicesTelemetryPolicy_networkServicesTelemetryPolicyBasicExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@pawelJas VCR tests complete for a86694e!

@pawelJas
pawelJas force-pushed the network_services_telemetry_policy branch 2 times, most recently from 021b510 to 0419db9 Compare July 17, 2026 12:11
@modular-magician

modular-magician commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 021b510:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 1954 insertions(+)
google-beta provider View Diff 5 files changed, 1954 insertions(+)
terraform-google-conversion View Diff 1 file changed, 358 insertions(+)
Open in Cloud Shell View Diff 8 files changed, 252 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_services_telemetry_policy (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_services_telemetry_policy" "primary" {
  metrics_configuration {
    metadata = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_network_services_telemetry_policy

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
103 99 2 2
Affected Service Packages
  • networkservices

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccNetworkServicesTelemetryPolicy_networkServicesTelemetryPolicyBasicExample
  • TestAccNetworkServicesTelemetryPolicy_networkServicesTelemetryPolicyFullExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccNetworkServicesTelemetryPolicy_networkServicesTelemetryPolicyBasicExample
❌ Error · Log - TestAccNetworkServicesTelemetryPolicy_networkServicesTelemetryPolicyFullExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@pawelJas VCR tests complete for 021b510!

@modular-magician

modular-magician commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 0419db9:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 1954 insertions(+)
google-beta provider View Diff 5 files changed, 1954 insertions(+)
terraform-google-conversion View Diff 1 file changed, 358 insertions(+)
Open in Cloud Shell View Diff 8 files changed, 252 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_services_telemetry_policy (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_services_telemetry_policy" "primary" {
  metrics_configuration {
    metadata = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_network_services_telemetry_policy

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
103 99 2 2
Affected Service Packages
  • networkservices

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccNetworkServicesTelemetryPolicy_networkServicesTelemetryPolicyBasicExample
  • TestAccNetworkServicesTelemetryPolicy_networkServicesTelemetryPolicyFullExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccNetworkServicesTelemetryPolicy_networkServicesTelemetryPolicyBasicExample
❌ Error · Log - TestAccNetworkServicesTelemetryPolicy_networkServicesTelemetryPolicyFullExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@pawelJas VCR tests complete for 0419db9!

@pawelJas
pawelJas force-pushed the network_services_telemetry_policy branch from 0419db9 to 58223fe Compare July 17, 2026 12:26
@modular-magician

modular-magician commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 58223fe:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 2030 insertions(+)
google-beta provider View Diff 5 files changed, 2030 insertions(+)
terraform-google-conversion View Diff 1 file changed, 358 insertions(+)
Open in Cloud Shell View Diff 12 files changed, 366 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_services_telemetry_policy (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_services_telemetry_policy" "primary" {
  metrics_configuration {
    metadata = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_network_services_telemetry_policy

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
104 99 2 3
Affected Service Packages
  • networkservices

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccNetworkServicesTelemetryPolicy_networkServicesTelemetryPolicyBasicExample
  • TestAccNetworkServicesTelemetryPolicy_networkServicesTelemetryPolicyFullExample
  • TestAccNetworkServicesTelemetryPolicy_networkServicesTelemetryPolicyGlobalExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccNetworkServicesTelemetryPolicy_networkServicesTelemetryPolicyBasicExample
❌ Error · Log - TestAccNetworkServicesTelemetryPolicy_networkServicesTelemetryPolicyFullExample
❌ Error · Log - TestAccNetworkServicesTelemetryPolicy_networkServicesTelemetryPolicyGlobalExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@pawelJas VCR tests complete for 58223fe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants