Skip to content

Add google_compute_service_attachments plural data source#18317

Open
vr-ibm wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
vr-ibm:add-service-attachments-plural-datasource
Open

Add google_compute_service_attachments plural data source#18317
vr-ibm wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
vr-ibm:add-service-attachments-plural-datasource

Conversation

@vr-ibm

@vr-ibm vr-ibm commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Fixes hashicorp/terraform-provider-google#23397

Adds a new plural data source google_compute_service_attachments that lists all service attachments in a given project and region, enabling discovery without hardcoding names or self_links.

Details

  • Calls the serviceAttachments.list compute API with pagination support
  • Accepts optional project, region, and filter arguments
  • Returns a service_attachments list with key attributes: name, self_link, target_service, connection_preference, nat_subnets, enable_proxy_protocol, domain_names, fingerprint, region
  • Adds acceptance test TestAccDataSourceGoogleComputeServiceAttachments_basic
  • Adds documentation

Tests

TestAccDataSourceGoogleComputeServiceAttachments_basic

Release Note Template for Downstream PRs (will be copied)

`google_compute_service_attachments`

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jul 17, 2026
@modular-magician

modular-magician commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit cc812dd:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 3 files changed, 417 insertions(+)
google-beta provider View Diff 3 files changed, 417 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
1548 1450 95 3
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeReservation_reservationSharingPolicyExample
  • TestAccDataSourceGoogleComputeServiceAttachments_basic

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccDataSourceGoogleComputeServiceAttachments_basic
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeReservation_reservationSharingPolicyExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@vr-ibm VCR tests complete for cc812dd!

@vr-ibm
vr-ibm marked this pull request as ready for review July 17, 2026 17:56
@vr-ibm
vr-ibm requested a review from BBBmau July 17, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unclear documentation for how to create regional Private Service Connect endpoints

2 participants