compute: added google_compute_service_attachments plural data source#18323
Open
vr-ibm wants to merge 1 commit into
Open
compute: added google_compute_service_attachments plural data source#18323vr-ibm wants to merge 1 commit into
google_compute_service_attachments plural data source#18323vr-ibm wants to merge 1 commit into
Conversation
Adds a new diff-processor subcommand that detects resources declaring ResourceIdentity but missing SetResourceIdentityAttributes calls in Create/Read/Update functions, or missing import identity tests (TestAcc*_importBlockWithResourceIdentity). Only resources changed in the PR (from schema diff) are checked, avoiding false positives on existing resources. This helps prevent PRs from introducing ResourceIdentity blocks without full CRUD coverage.
modular-magician
added
awaiting-approval
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 26d416e: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
Collaborator
Author
|
/gcbrun |
vr-ibm
marked this pull request as ready for review
July 17, 2026 21:52
modular-magician
added
the
awaiting-approval
modular-magician
removed
the
awaiting-approval
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 26d416e: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new plural data source
google_compute_service_attachmentsthat lists all service attachments in a given project and region, enabling discovery without hardcoding names or self_links.Details
serviceAttachments.listcompute API with pagination supportproject,region, andfilterargumentsservice_attachmentslist with key attributes:name,self_link,target_service,connection_preference,nat_subnets,enable_proxy_protocol,domain_names,fingerprint,regionTestAccDataSourceGoogleComputeServiceAttachments_basicTests
TestAccDataSourceGoogleComputeServiceAttachments_basicRelease Note Template for Downstream PRs (will be copied)