Replace ordering key prober's --should_cleanup with --should_not_cleanup so that we can use the flag#411
Merged
kamalaboulhosn merged 3 commits intoGoogleCloudPlatform:masterfrom Apr 6, 2026
Conversation
…nup so that we can use the flag The current implmenetation will not be able to disable the flag (i.e., specify that I don't want to cleanup). This can be resolved by adding `arity=1` in the @parameter() (see https://jcommander.org/ section 2.1), but I try to keep the style consistent with `--no_publish` flag.
kamalaboulhosn
requested changes
Apr 6, 2026
|
|
||
| @Parameter(names = "--should_cleanup", description ="Whether the prober should start by cleaning up the topic and subscription.") | ||
| private boolean shouldCleanup = true; | ||
| @Parameter(names = "--should_not_cleanup", description = "Whether the prober should start by not cleaning up the topic and subscription.") |
Collaborator
There was a problem hiding this comment.
Can we just call it no_cleanup?
|
|
||
| @Parameter(names = "--should_cleanup", description ="Whether the prober should start by cleaning up the topic and subscription.") | ||
| private boolean shouldCleanup = true; | ||
| @Parameter(names = "--should_not_cleanup", description = "Whether the prober should start by not cleaning up the topic and subscription.") |
Collaborator
There was a problem hiding this comment.
Adding just a "not" in the description is confusing. Let's change it to "Skip the cleanup of the topic and subscription on startup."
Collaborator
Author
There was a problem hiding this comment.
Revised the flag description per suggestion.
added 2 commits
April 6, 2026 20:09
kamalaboulhosn
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation will not be able to disable the flag (i.e., specify that I don't want to cleanup). This can be resolved by adding
arity=1in the @parameter() (see https://jcommander.org/ section 2.1), but I try to keep the style consistent with--no_publishflag, I decide to just introduce the negation in the flag name.