Skip to content

docs(alloydb): Add AlloyDB Vector Search Benchmark Colab - #14444

Closed
vinay0410 wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
vinay0410:feature/alloydb-vector-search-benchmark
Closed

docs(alloydb): Add AlloyDB Vector Search Benchmark Colab#14444
vinay0410 wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
vinay0410:feature/alloydb-vector-search-benchmark

Conversation

@vinay0410

Copy link
Copy Markdown
Contributor

Description

Fixes #

Checklist

Testing

  • I have tested this change on a live environment and verified it works as intended.

Compliance & Style


Post-Approval Actions

  • Please merge this PR for me once it is approved

@vinay0410
vinay0410 requested review from a team as code owners July 21, 2026 10:49
@product-auto-label product-auto-label Bot added api: alloydb Issues related to the AlloyDB API. samples Issues that are directly related to samples. api: notebooks Issues related to the Agent Platform Workbench API. labels Jul 21, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds an end-to-end test test_alloydb_vector_search_benchmark to run a benchmark notebook with reduced parameters in CI. The reviewer identified that the notebook filename and variable keys for the cluster and instance names are incorrect, which would cause the test to fail, and provided a code suggestion to correct them.

Comment on lines +170 to +175
"alloydb_vector_search_benchmark.ipynb",
variables={
"project_id": project_id,
"region": region,
"cluster_id": cluster_name,
"instance_id": instance_name,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The notebook filename and the variable keys for the cluster and instance names do not match the actual notebook file (columnar_engine_accelerated_hnsw_vector_search_benchmark.ipynb). This will cause the end-to-end test to fail as the file won't be found, and the variables won't be correctly substituted.

Please update the notebook filename and use cluster_name and instance_name as the keys in the variables dictionary.

Suggested change
"alloydb_vector_search_benchmark.ipynb",
variables={
"project_id": project_id,
"region": region,
"cluster_id": cluster_name,
"instance_id": instance_name,
"columnar_engine_accelerated_hnsw_vector_search_benchmark.ipynb",
variables={
"project_id": project_id,
"region": region,
"cluster_name": cluster_name,
"instance_name": instance_name,

@vinay0410 vinay0410 closed this Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: alloydb Issues related to the AlloyDB API. api: notebooks Issues related to the Agent Platform Workbench API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant