docs(alloydb): Add AlloyDB Vector Search Benchmark Colab - #14444
docs(alloydb): Add AlloyDB Vector Search Benchmark Colab#14444vinay0410 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds an end-to-end test test_alloydb_vector_search_benchmark to run a benchmark notebook with reduced parameters in CI. The reviewer identified that the notebook filename and variable keys for the cluster and instance names are incorrect, which would cause the test to fail, and provided a code suggestion to correct them.
| "alloydb_vector_search_benchmark.ipynb", | ||
| variables={ | ||
| "project_id": project_id, | ||
| "region": region, | ||
| "cluster_id": cluster_name, | ||
| "instance_id": instance_name, |
There was a problem hiding this comment.
The notebook filename and the variable keys for the cluster and instance names do not match the actual notebook file (columnar_engine_accelerated_hnsw_vector_search_benchmark.ipynb). This will cause the end-to-end test to fail as the file won't be found, and the variables won't be correctly substituted.
Please update the notebook filename and use cluster_name and instance_name as the keys in the variables dictionary.
| "alloydb_vector_search_benchmark.ipynb", | |
| variables={ | |
| "project_id": project_id, | |
| "region": region, | |
| "cluster_id": cluster_name, | |
| "instance_id": instance_name, | |
| "columnar_engine_accelerated_hnsw_vector_search_benchmark.ipynb", | |
| variables={ | |
| "project_id": project_id, | |
| "region": region, | |
| "cluster_name": cluster_name, | |
| "instance_name": instance_name, |
Description
Fixes #
Checklist
Testing
Compliance & Style
Post-Approval Actions