Skip to content

build(deps): update keras and adjust e2e test configuration - #14599

Merged
XrossFox merged 3 commits into
GoogleCloudPlatform:mainfrom
XrossFox:dependabot-update-keras
Sep 18, 2026
Merged

XrossFox merged 3 commits into
GoogleCloudPlatform:mainfrom
XrossFox:dependabot-update-keras

Conversation

@XrossFox

@XrossFox XrossFox commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Description

Bumps keras to version 3.15.1 and updates pyOpenSSL in the Dataflow gemma requirements to resolve Dependabot security alerts. Also updates e2e_test.py to read the GEMMA_GCS bucket path
from the environment.

Tested locally: note, due to the docker image, this sample only runs on python 3.11.

image

Fixes b/558735949

Checklist

Testing

  • I have tested this change on a live environment and verified it works as intended.

Compliance & Style


Post-Approval Actions

  • Please merge this PR for me once it is approved

 Bumps `keras` to version 3.15.1 and updates `pyOpenSSL` in the Dataflow gemma requirements to resolve Dependabot security alerts. Also updates `e2e_test.py` to read the `GEMMA_GCS` bucket path
 from the environment.
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Sep 9, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates dependencies in requirements.txt and modifies e2e_test.py to retrieve the GEMMA_GCS path from an environment variable instead of using a hardcoded string. The feedback suggests providing a default fallback value for os.getenv("GEMMA_GCS") to prevent potential runtime errors if the environment variable is not set.

Comment thread dataflow/gemma/e2e_test.py Outdated

@angelcaamal angelcaamal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@XrossFox
XrossFox marked this pull request as ready for review September 17, 2026 17:08
@XrossFox
XrossFox requested review from a team as code owners September 17, 2026 17:08
@XrossFox
XrossFox merged commit 5e143ef into GoogleCloudPlatform:main Sep 18, 2026
10 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants