Skip to content

fix debian-security timestamp selection #2083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loosebazooka merged 1 commit into from
May 11, 2026
+1 −1
Merged

fix debian-security timestamp selection #2083

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion knife
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ function find_latest_snapshot() {
local current="$(date -d '-1 day' +%Y-%m-%d)"
local tmp=$(mktemp)
local q=$(date -d "$current" +"year=%Y&month=%m")
if curl -fs "https://snapshot.debian.org/archive/debian/?$q" | grep -ohE "([0-9]+T[0-9]+Z)" > $tmp; then
if curl -fs "https://snapshot.debian.org/archive/${type}/?$q" | grep -ohE "([0-9]+T[0-9]+Z)" > $tmp; then
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The regex used to identify snapshot timestamps can be made more robust by specifying the exact format (YYYYMMDDTHHMMSSZ). The current pattern [0-9]+T[0-9]+Z is quite loose and could potentially match other strings in the HTML. Additionally, using curl -fSs instead of curl -fs is recommended as it will display error messages on stderr if the request fails, which aids in debugging while still remaining silent on success. The -h flag for grep is also redundant when reading from a pipe.

    if curl -fSs "https://snapshot.debian.org/archive/${type}/?$q" | grep -oE "[0-9]{8}T[0-9]{6}Z" > "$tmp"; then

# same logic as above, find the newest snapshot that isn't "today"
today=$(date +"%Y%m%dT")
cat $tmp | grep -v $today | tail -n1
Expand Down
Loading