refactor nodejs build code#2087
Merged
Merged
Conversation
Signed-off-by: Appu <appu@google.com>
Contributor
|
🌳 🔧 Config Check This pull request has not modified the root BUILD |
omBratteng
approved these changes
May 13, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the Node.js image build process by moving package management from hardcoded logic in nodejs.bzl to a configurable mapping in config.bzl. Feedback focuses on maintaining backward compatibility by providing a default value for the new packages argument, optimizing the construction of package tars outside of nested loops, using safer dictionary access to prevent build failures, and restoring documentation regarding the libatomic1 requirement.
Contributor
|
🌳 🔄 Image Check This pull request has modified the following images: //nodejs:nodejs26_nonroot_amd64_debian13
//nodejs:nodejs26_root_amd64_debian13
//nodejs:nodejs26_debug_root_amd64_debian13
//nodejs:nodejs26_debug_nonroot_amd64_debian13
//nodejs:nodejs26_root_amd64_debian13
//nodejs:nodejs26_debug_nonroot_arm64_debian13
//nodejs:nodejs26_debug_root_arm64_debian13
//nodejs:nodejs26_nonroot_amd64_debian13
//nodejs:nodejs26_debug_root_arm64_debian13
//nodejs:nodejs26_root_arm64_debian13
//nodejs:nodejs26_debug_root_amd64_debian13
//nodejs:nodejs26_debug_root_s390x_debian13
//nodejs:nodejs26_root_s390x_debian13
//nodejs:nodejs26_debug_nonroot_s390x_debian13
//nodejs:nodejs26_debug_root_s390x_debian13
//nodejs:nodejs26_debug_nonroot_s390x_debian13
//nodejs:nodejs26_nonroot_s390x_debian13
//nodejs:nodejs26_nonroot_s390x_debian13
//nodejs:nodejs26_debug_nonroot_arm64_debian13
//nodejs:nodejs26_debug_root_ppc64le_debian13
//nodejs:nodejs26_root_ppc64le_debian13
//nodejs:nodejs26_nonroot_arm64_debian13
//nodejs:nodejs26_nonroot_arm64_debian13
//nodejs:nodejs26_root_arm64_debian13
//nodejs:nodejs26_nonroot_ppc64le_debian13
//nodejs:nodejs26_debug_root_ppc64le_debian13
//nodejs:nodejs26_root_ppc64le_debian13
//nodejs:nodejs26_root_s390x_debian13
//nodejs:nodejs26_debug_nonroot_amd64_debian13
//nodejs:nodejs26_debug_nonroot_ppc64le_debian13
//nodejs:nodejs26_debug_nonroot_ppc64le_debian13
//nodejs:nodejs26_nonroot_ppc64le_debian13You can check the details in the report here |
patflynn
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.