Skip to content

Use the non-deprecated depends_on macos symbol form#13

Merged
GordonBeeming merged 1 commit into
mainfrom
gb/fix-depends-on-macos
Jul 8, 2026
Merged

Use the non-deprecated depends_on macos symbol form#13
GordonBeeming merged 1 commit into
mainfrom
gb/fix-depends-on-macos

Conversation

@GordonBeeming

Copy link
Copy Markdown
Owner

Homebrew deprecated the string comparison form of depends_on macos in casks. This swaps ">= :sonoma" for the bare symbol :sonoma in both the packaging script and the CI-generated cask so they stay in sync. Same meaning (Sonoma or newer), just the current Homebrew syntax.

Homebrew deprecated the string comparison form (">= :sonoma") for
depends_on macos in casks; the bare symbol form (:sonoma) means the
same thing (Sonoma or newer) without the deprecation warning. Updates
both the packaging script and the CI-generated cask so they stay in
sync.

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: GitButler <gitbutler@gitbutler.com>
@GordonBeeming GordonBeeming marked this pull request as ready for review July 8, 2026 11:03
Copilot AI review requested due to automatic review settings July 8, 2026 11:03

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Homebrew cask definition in Scripts/package-for-homebrew.sh to simplify the macOS dependency specification from depends_on macos: ">= :sonoma" to depends_on macos: :sonoma. There are no review comments, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Homebrew Cask macOS dependency syntax to the current, non-deprecated form so the generated cask and the packaging script remain aligned with Homebrew’s expectations.

Changes:

  • Replace depends_on macos: ">= :sonoma" with depends_on macos: :sonoma in the packaging script cask template.
  • Apply the same update to the CI workflow’s generated vista.rb cask content to keep both sources in sync.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Scripts/package-for-homebrew.sh Updates the cask snippet to use the non-deprecated depends_on macos: :sonoma syntax.
.github/workflows/build.yml Keeps the CI-generated tap cask output in sync with the updated depends_on macos: syntax.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@GordonBeeming GordonBeeming merged commit cd38bbe into main Jul 8, 2026
3 checks passed
@GordonBeeming GordonBeeming deleted the gb/fix-depends-on-macos branch July 8, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants