fix: use static tokio runtime to prevent shutdown during sync#4044
Merged
djmitche merged 2 commits intoGothenburgBitFactory:developfrom Feb 1, 2026
Merged
fix: use static tokio runtime to prevent shutdown during sync#4044djmitche merged 2 commits intoGothenburgBitFactory:developfrom
djmitche merged 2 commits intoGothenburgBitFactory:developfrom
Conversation
The runtime was being dropped immediately after getting its Handle, causing panics during async sync operations. Use a static OnceLock to keep the runtime alive for the program's lifetime. Also enables all Tokio features (time, io) needed for sync.
Collaborator
|
Oops, I just saw this after merging #4042. This looks like a better fix! Why close it? |
Collaborator
|
I will rebase and adopt this! (and figure out how to test this more effectively) |
Collaborator
|
I confirmed that with this change applied my local GCP sync works fine. |
djmitche
approved these changes
Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4040.
Problem
The
rt()function creates a new Tokio runtime on each call, returns itsHandle, and immediately drops the runtime. This causes panics during sync operations:Solution
Use
OnceLockto create a single static runtime that lives for the program's lifetime. Also useenable_all()to enable both time and IO features needed for sync operations.Changes
Note: PR #4042 adds
.enable_time()which addresses the "timers are disabled" error but doesn't fix the underlying runtime lifetime issue.