Handle tooltip lines with no left text - #168
Open
AndyMM22 wants to merge 1 commit into
Open
Conversation
Owner
|
There is no issue reported with details on which WoW version, Outfitter version, or the specific error encountered. Can you supply that in an issue? |
Author
|
Filed as #170, with the versions and a captured stack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blank separator lines have no leftText.
ParseTooltipLine indexes it during inventory sync -- full stack in #170.
ParseGemLinkForUniqueEquips calls line.leftText:match the same way; that fires when hovering a gemmed item.
TooltipLeftLines returns leftText straight into a generic for, and nil ends the loop, so StatsForTooltip stops at the first separator.