Skip to content

Make overview buses inspectable with endpoint highlighting #231

Closed

Description

@mvalancy

Overview buses currently ignore pointer input, so users cannot inspect a visible connection or see which groups it joins. The owner reported this on 2026-10-28 along with crowded placement. This issue delivers the interaction slice of #220; automatic placement and detailed obstacle routing remain there.

Done

  • Verified the root cause in SemanticGraphOverview: SVG bus paths inherit pointer-events:none and only contain native SVG titles.

Next

  • Add generous pointer targets and keyboard activation for visible buses, with a readable directed summary.
  • Emphasize both endpoint cards while hovering/focusing a connection; preserve canonical selection, authored positions and camera.
  • Open the existing relationship browser with the exact represented original IDs/types/directions and restore focus on return. Clear transient emphasis across view/cut/trace changes.
  • Add real pointer/keyboard regression checks and scale coverage using the existing 2,000-node/5,000-edge fixture, including no inspection writes and full relationship conservation.
  • Independent review, complete gates and actual post-dev acceptance before closure.

Resume: branch feat/overview-bus-inspection-20261028, dev baseline 00f0211. Main component packages/web/src/components/SemanticGraphOverview.tsx; relationship scope and browser must agree. Preserve the bounded router and honest deferred-connection counts. No data changes to original localhost graphs, release or deployment are included.

Activity

  1. mvalancy commented on Oct 29, 2026

    @mvalancy
    MemberAuthor

    PR #232 is pushed at 3e2f7e1e61628c1f14c39e52fe72613afc4184b2, with independent source/artifact review assigned. Visible buses now support real pointer input, keyboard activation, endpoint emphasis and exact-original inspection; captions seek free space and focus survives route removal or overview exit.

    Local final acceptance: 19 focused tests, web types and scoped lint pass. Existing desktop/phone 301-item journeys pass 2/2 in 91.07s, one headed browser/worker, no retries, retaining camera/source/write guards. Both bus screenshots and file-backed identity/geometry receipts are retained for review. The existing 2,000-item/5,000-edge headless journey carries the same interaction checks; final hosted proof is pending in CI40795185967 and Comprehensive40795185994. Earlier source build/type failures and corrections remain in the PR.

    Next: independent review, actual final artifact audit and dev integration/post-dev acceptance. #220 still owns wider routing corridors, bounded iterative organization and detailed obstacle routing. Do not close that issue for this interaction slice.

  2. mvalancy commented on Oct 29, 2026

    @mvalancy
    MemberAuthor

    Committed/pushed8f6e6afb0bb8a0176269ffef89de167995e0272a on feat/overview-bus-inspection-20261028; PR232 now composes live dev4b825b12a752f54531a2263816630501396eabb8. Both independent input findings corrected, replied on their threads, and sent for exact-source re-review.23units, types, scoped lint, real overlap control1/1 and actual301desktop/phone2/2(93.90s) pass. See PR description for retained failures and canonical lessons.

    Running on GitHub-hosted runners: CI40798940305 and Comprehensive40798940275. Resume with gh run view 40798940305 --repo GraphDone/GraphDone-Core; download actual smoke artifact and audit13strictreports116cases including2k/5k bus input and new standalone overlap. Pending independent clearance, hosted gates, dev-only exact-head integration and actual post-dev audit before closing231. Spacing/auto-placement and detailed routing remain separate unfinished work.

  3. mvalancy commented on Oct 29, 2026

    @mvalancy
    MemberAuthor

    The actual-dev acceptance blocker has now passed in merge 479edf61a2e5f964de9034b6b7da26d2ffb4c11f, following the hidden-rendering correction #235 / PR #236. Actual CI 40820579099 and Comprehensive 40820579055 are green; the actual strict archive has 13 clean-source reports, 117 passing cases and 140 valid attachments.

    Author audit of the actual bus receipts confirms the 2k case exposes exactly 143 original directed relationship IDs, while the desktop/phone 301-item cases each expose their expected two originals. All three receipts show a 24px hit target, exactly two highlighted endpoints, and bounded 14px / 600-weight captions with zero text overflow. The existing actual pointer/keyboard/shared-branch controls and camera/focus/no-write guards passed. The actual 2k load was 22.190 s and browser zooms 3.0525 / 2.9758 / 3.5721 s under unchanged guards.

    A separate non-author reviewer is checking the complete actual-commit receipts and PNGs now. This issue remains open for the repository owner to close after that final acceptance. Dense local organization, offscreen connections and broader spacing remain #233/#220 scope.

  4. mvalancy commented on Oct 29, 2026

    @mvalancy
    MemberAuthor

    The outstanding actual post-dev blocker is resolved by merged PR236. Independent acceptance of actual dev479edf61a2e5f964de9034b6b7da26d2ffb4c11f is recorded at #236 (comment) . Both complete workflows pass;13 strict reports/117 cases/140 valid attachments are verified.

    Actual pointer/keyboard bus controls preserve nearest-wire and shared-branch ownership, both endpoint highlights, readable tooltip and exact original IDs (143 in the2k bus inspection,2 in each301 case). Full2k final identity/camera/no-write/error guards now complete with all zooms below the unchanged5s limit. This completes the interaction slice’s post-dev acceptance; the owner can close #231. Automatic placement/detailed route clarity remain #220/#233/#234, and the prior failed integration is still retained. Reviewer did not close this issue.

  5. mvalancy commented on Oct 29, 2026

    @mvalancy
    MemberAuthor

    Resolved by PR #236, native exact-head administrative merge into dev at 479edf61a2e5f964de9034b6b7da26d2ffb4c11f. Actual post-dev CI 40820579099 and Comprehensive 40820579055 pass, independently audited after merge.

    The actual archive contains13 strict reports/117 passing cases/140 valid attachments, no failed/warned/skipped cases; fresh packaged/runtime checks and exact parents/tree pass. Actual2k/5k load22.190s, browser zoom3.0525/2.9758/3.5721s under the unchanged5s gate (bridge wall4.197/4.042/4.990s); no view writes/errors, unchanged final snapshot, hidden terminal passes4→4, item return5. Real bus/arrow/pointer/keyboard evidence accepted. Independent final evidence.

    Earlier actual-dev17acc25's5.119s failure remains recorded in #235. This closes the corrected overview rendering/interaction issue only; dense local Items/placement remains tracked separately in #233/PR #234 and arbitrary detailed wiring in #220.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions