Repository navigation
Patch the MCP Zod dependency and verify real SDK validation boundaries - #180
Conversation
🧪 Comprehensive Test Suite
Full-stack smoke gate runs in the CI workflow. |
|
Independent review at 234fcc8: no blocking finding in this seven-file scope. This comment does not satisfy protected
Limits are accurate: upstream's constrained-collection fix leaves unbounded collections unchanged. The completion-schema regression is an SDK surface, not a registered Core completion endpoint. This does not establish general MCP denial-of-service protection, all JSON-schema enforcement, hosted deployment, or broad authentication security. The stdout correction and combined nine-case real-entrypoint/DB validation are tracked separately in #179. No source changes were made during this review. |
🧪 Comprehensive Test Suite
Full-stack smoke gate runs in the CI workflow. |
|
Follow-up review completed at c041814. No blocking finding. Since reviewed Independently inspected retained combined-candidate evidence for The separate compiled-entrypoint probe reports success, initialization, 31 listed tools, owned graph reads, malformed/unknown-call rejection and recovery, independent DB readback, and zero protocol errors. Recorded cleanup confirms child termination, one edge, two nodes and one graph removed, then all owned identifiers absent. The documentation correctly separates this one-off probe from the committed contract tests and preserves the pending final public CI/non-author approval boundary. This follow-up inspected existing artifacts and the documentation delta; no tests, browsers, database probes or builds were rerun. Earlier exact-head source/dependency/fixture review remains applicable. These local combined results are not deployment evidence or a substitute for the new final integration-head checks. |
The fresh production audit on unchanged integration
78a90ccnow rejects Zod 3.25.76 under GHSA-mrhx-c7xc-m3w5, although an earlier CI response omitted it. This pins MCP's dependency to patched Zod 4.6.7 and resolves the actual hoisted SDK consumer to that version. SDK 1.32.2 stays unchanged; no application source directly imports Zod.The audit step receives a separate cache under the runner temporary directory for each run attempt. The install cache and high/critical threshold remain unchanged. This removes restored audit-cache reuse as one variable; the earlier discrepancy's cause and registry freshness are not claimed.
Validation:
The actual SDK fixtures cover initialization, tool listing/calling, metadata/defaults, malformed params/results, recovery and bounded stdio parsing. They do not launch GraphDone's real entry point. The separate actual-process check found stdout diagnostic contamination, tracked in PR #179; that correction and its real Neo4j/stdio regression remain separate.
This closes the observed dependency finding, not all MCP resource-exhaustion risk: unbounded collections are unchanged, Core does not register the tested completion endpoint, and tool JSON-schema declarations are not made universally enforced by this update. Final combined integration CI and non-author review of #157 remain required. No deployment occurred.
Tracks #156.