Skip to content

Patch Turbo and Mermaid with executed consumer contracts - #212

Merged
mvalancy merged 3 commits into
devfrom
fix/remaining-tooling-security-20261027
Oct 28, 2026
Merged

mvalancy merged 3 commits into
devfrom
fix/remaining-tooling-security-20261027

Conversation

@mvalancy

Copy link
Copy Markdown
Member

The remaining npm tooling findings require compatible Turbo and Mermaid upgrades. This updates Turbo to 2.11.10 and Mermaid to 12.2.0, with patched KaTeX consumers, while preserving task environment behavior and the existing diagram rendering expectation.

Part of #185; stacked on runtime packaging #211. Exact source 525ca4e5aa5bd4a918ad85165d0f2a0e8caf59ac includes the reviewed camera corrections.

Turbo uses the new task schema and the existing npm package manager, with explicit loose environment mode preserving 1.x behavior. An installed executable contract proves dependency ordering, environment passthrough, build-flag cache invalidation, an actual cache hit and real upstream failure propagation without running its dependent. Mermaid resolves from the declaring web workspace; export acceptance selects dagre/default/classic explicitly. The app still exports text and does not bundle Mermaid.

Validation:

  • Clean Node 22.18/npm 10.8.2 install; fresh full and production audits both zero findings.
  • Build/types/lint pass; coverage 715 passing tests plus the existing 26 explicit database skips; harness 192/192. Real database acceptance remains a separate required CI gate.
  • Three installed Vite/Turbo/Mermaid contracts pass on Node 22.18 and 24.22.1. Old KaTeX 0.16.47 fails the inherited-trust negative; patched installed 0.18.10 rejects it. Mermaid's actual IIFE embeds patched 0.18.11.
  • Final composed offline build and full portable-project browser journey pass in 27.7 seconds, one worker, zero retries, including real exported diagram rendering and zero sync writes.
  • Independent implementation review repeated the new contracts and KaTeX negative and verified dependency changes are confined to these two families. Final documentation review and exact-head CI remain pending.

The initial Turbo negative probe failed at CLI parsing because two flags were mutually exclusive; that failure is retained and not credited as executed task failure. The final regression requires the actual child's unique marker. Full provenance and limits are in docs/quality/REMAINING_TOOLING_2026-10-27.md.

Mermaid's newer browser floor applies to this tooling renderer, not GraphDone's unchanged application target. Debian OS residuals remain #209. No registry publication, release, main promotion or deployment is included.

@mvalancy

Copy link
Copy Markdown
Member Author

Independent final review clears exact head 525ca4e5aa5bd4a918ad85165d0f2a0e8caf59ac. The implementation was reviewed at 9440f0c; full recursive comparison proves only four explicit documentation paths changed afterward, with every other mode/blob identical. The reviewer independently repeated Turbo/Mermaid contracts and the old/new KaTeX negative, verified lock scope and checked all recorded local results against evidence. Final exact-head CI and subsequent dev validation remain required; this is independent agent review, not a GitHub non-author approval.

@github-actions

Copy link
Copy Markdown

🧪 Comprehensive Test Suite

  • Unit suites (Node 22.18.0 & 24.x) — core, web, server, mcp-server: ✅ passed
  • Installer & deploy config: ✅ passed

Full-stack smoke gate runs in the CI workflow.

@mvalancy
mvalancy changed the base branch from fix/runtime-image-packaging-20261027 to dev October 28, 2026 00:19
@mvalancy
mvalancy marked this pull request as ready for review October 28, 2026 00:19
@mvalancy

Copy link
Copy Markdown
Member Author

Final native dev integration evidence for source 525ca4e5aa5bd4a918ad85165d0f2a0e8caf59ac, the reviewed Turbo/Mermaid completion atop runtime packaging. Independent implementation and final documentation reviews found no findings; the complete four-document final delta preserves every tested implementation blob.

CI40603731170 and Comprehensive40603731223 passed every applicable job, including both supported Node versions and all three actual runtime image contracts. Strict artifacts verify smoke6, new-user42, LOD2, routes7, mobile27 and performance3 without failures, warnings, skipped cases, timeouts or evidence errors. Effects/showcase and installed Vite/Turbo/Mermaid contracts also passed. Fresh full and production npm audits are zero; prior negative evidence is retained.

Downloaded final image inventories again record zero npm findings for all images, zero OS findings for Alpine API/generic, and228 retained Debian OS entries for self-host. #209 remains open; this is not full-image or deployed-site clearance.

The live base must equal the preceding reviewed runtime tree, and the complete merge result must equal cffa8b8a7903b9609603f1c42978511d900678f6. Native integration uses standing dev-only admin authority and is not a non-author GitHub approval. Issue closeout waits for final integrated dev CI; superseded intermediate runs are not credited as passes. Main, release, deployment and protection remain unchanged.

@mvalancy
mvalancy merged commit 780a759 into dev Oct 28, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant