refactor: use standardized swift-async-algorithms#22
refactor: use standardized swift-async-algorithms#22Austinpayne wants to merge 2 commits intoGraphQLSwift:mainfrom
Conversation
Adopts the more common (now-a-days) swift-async-algorithms for the simple async collection needs of this package. Helps adopt the standardized ecosystem where many other packages use swift-async-algorithms.
|
I believe if you change this line from DataLoader/.github/workflows/build.yml Line 54 in 52b1f3d |
NeedleInAJayStack
left a comment
There was a problem hiding this comment.
Looks great, thanks @Austinpayne
paulofaria
left a comment
There was a problem hiding this comment.
LGTM! Thank you for your contribution! 🙂
Sweet, thanks! Pushed up a change to upgrade to v4. |
|
You replaced |
|
Yeah, it's true the semantics are different. Feel free to close if this potential performance change is unacceptable. I don't see any benchmarks in this package so I don't have a good way to qualify this change. |
|
I'm inclined to agree with @ZirgVoice. Batching works by slightly pausing execution to allow more I'm realizing that we ought to add a test that validates this functionality for |
|
Sounds good, thanks for the feedback! |
Adopts the more common (now-a-days) swift-async-algorithms for the simple async collection needs of this package. Helps adopt the standardized ecosystem where many other packages use swift-async-algorithms.