Add support for specifying expected video bitrate while recording #548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(in more settings screen/page)
(for video bitrate setting UI)
* Add a class CustomNumFilter that ensures only number is present on the field the filter is applied to * Use the custom CustomNumFilter for NumInputFilter (old) or now NumLimFilter (new) class * Shift the two input filter classes to a separate package (app.grapheneos.camera.inputfilter)
(for video bitrate setting)
MHShetty
force-pushed
the
video_bitrate_setting
branch
from
0c91e7b to
208af9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to specify a target bitrate while recording a video. Implements the feature request described in issue #487