Add support for preview inversion #557
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(to fixing inversion for front camera)
(while corresponding settings are enabled)
ghost
reviewed
Oct 16, 2025
| previewBuilder.setPreviewStabilizationEnabled(false) | ||
| } | ||
|
|
||
| // Adapt |
There was a problem hiding this comment.
Suggested change
| // Adapt | |
| val shouldMirror = lensFacing == CameraSelector.LENS_FACING_FRONT && | |
| ((isVideoMode && saveVideoAsPreviewed) || (isInPhotoMode && saveImageAsPreviewed)) | |
| previewBuilder.setMirrorMode( | |
| if (shouldMirror) MirrorMode.MIRROR_MODE_ON | |
| else MirrorMode.MIRROR_MODE_OFF | |
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to resolve issue #497. It includes preview inversion support for existing save image/video as previewed toggle as renames them to "Fix inversion of camera" toggle for photo and video individually. Unifying it further might need us to get away with the existing toggles/preferences