Bump pdfjs-dist from 5.6.205 to 5.7.284#633
Open
ggtlvkma356 wants to merge 1 commit intoGrapheneOS:mainfrom
Open
Bump pdfjs-dist from 5.6.205 to 5.7.284#633ggtlvkma356 wants to merge 1 commit intoGrapheneOS:mainfrom
ggtlvkma356 wants to merge 1 commit intoGrapheneOS:mainfrom
Conversation
inthewaves
suggested changes
Apr 29, 2026
Member
There was a problem hiding this comment.
Our index.js passes isEvalSupported to getDocument:
globalThis.loadDocument = function () {
const pdfPassword = channel.getPassword();
const loadingTask = getDocument({
url: "https://localhost/placeholder.pdf",
cMapUrl: "https://localhost/viewer/cmaps/",
cMapPacked: true,
password: pdfPassword,
iccUrl: "https://localhost/viewer/iccs/",
isEvalSupported: false,
However, pdf.js removes isEvalSupported in mozilla/pdf.js@f6bac01 (not an error because of JavaScript permissiveness... thanks JavaScript!). It seems like a legacy option to me, but we should make sure that having it removed is fine
59073ca to
47f05a5
Compare
Contributor
Author
|
|
Member
|
We'd need to check if |
47f05a5 to
066e96b
Compare
Contributor
Author
|
Wasm is currently disabled by CSP, see #634 |
066e96b to
2c8193a
Compare
inthewaves
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersede #632
Math.sumPrecise