Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions graphify/dedup.py
Original file line number Diff line number Diff line change
Expand Up @@ -417,11 +417,16 @@ def deduplicate_entities(

total = len(remap)
msg = f"[graphify] Deduplicated {total} node(s)"
# Both counters are reported when non-zero. Previous form nested the fuzzy
# branch inside `if exact_merges`, silently dropping the fuzzy count on
# doc/semantic-heavy runs where Pass 1 finds nothing (#1857).
parts: list[str] = []
if exact_merges:
msg += f" ({exact_merges} exact"
if fuzzy_merges:
msg += f", {fuzzy_merges} fuzzy"
msg += ")"
parts.append(f"{exact_merges} exact")
if fuzzy_merges:
parts.append(f"{fuzzy_merges} fuzzy")
if parts:
msg += f" ({', '.join(parts)})"
print(msg + ".", flush=True)

deduped_nodes = [n for n in unique_nodes if n["id"] not in remap]
Expand Down
36 changes: 36 additions & 0 deletions tests/test_dedup.py
Original file line number Diff line number Diff line change
Expand Up @@ -404,3 +404,39 @@ def test_same_id_same_source_file_no_warning(capsys):
assert len(result_nodes) == 1
captured = capsys.readouterr()
assert "WARNING" not in captured.err


# ── #1857: dedup summary log breakdown ────────────────────────────────────────

def test_dedup_summary_prints_fuzzy_count_when_no_exact_merges(capsys):
"""A fuzzy-only run must still report the fuzzy count (#1857).

Two long, high-entropy, non-code labels on different files. Pass 1 (exact,
same-file) finds nothing; Pass 2 (Jaro-Winkler cross-file) merges them.
Previously the fuzzy count was nested inside `if exact_merges`, so this
line printed as `Deduplicated 1 node(s).` with no breakdown.
"""
nodes = [
{"id": "g1", "label": "GraphExtractor", "file_type": "concept", "source_file": "a.md"},
{"id": "g2", "label": "Graph Extractor", "file_type": "concept", "source_file": "b.md"},
]
result_nodes, _ = deduplicate_entities(nodes, [], communities={})
assert len(result_nodes) == 1
captured = capsys.readouterr()
assert "Deduplicated" in captured.out
assert "fuzzy" in captured.out
assert "exact" not in captured.out


def test_dedup_summary_still_reports_exact_only(capsys):
"""Non-regression: an exact-only run still prints `(N exact)` and no fuzzy."""
# Same file + same normalized label → Pass 1 exact merge.
nodes = [
{"id": "u1", "label": "User Service", "file_type": "concept", "source_file": "svc.md"},
{"id": "u2", "label": "user service", "file_type": "concept", "source_file": "svc.md"},
]
result_nodes, _ = deduplicate_entities(nodes, [], communities={})
assert len(result_nodes) == 1
captured = capsys.readouterr()
assert "exact" in captured.out
assert "fuzzy" not in captured.out