Skip to content

Consolidate the rank promotion and cache chain registrations behind one value-type list#4346

Merged
Keavon merged 1 commit into
masterfrom
consolidate-registry-lists
Jul 16, 2026
Merged

Consolidate the rank promotion and cache chain registrations behind one value-type list#4346
Keavon merged 1 commit into
masterfrom
consolidate-registry-lists

Conversation

@Keavon

@Keavon Keavon commented Jul 16, 2026

Copy link
Copy Markdown
Member

Removes a few lines of code and makes this more maintainable, and fixes a few obscure missing type monomorphizations.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors node_registry.rs by introducing a new macro ranked_value_types! to consolidate the list of value and enum element types used for ranked wires. This eliminates duplication between the rank promotion adapters and the cache chain registrations, ensuring consistency. Additionally, several imports have been updated to support this consolidation. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@Keavon
Keavon merged commit d241cdc into master Jul 16, 2026
10 checks passed
@Keavon
Keavon deleted the consolidate-registry-lists branch July 16, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant