Skip to content

Add bool-to-number auto conversion, rename 'As f64' to 'As Number', and add 'Is Nonzero' and 'As Bool' nodes - #4567

Merged
Keavon merged 1 commit into
masterfrom
booleans-as-numbers
Sep 21, 2026
Merged

Keavon merged 1 commit into
masterfrom
booleans-as-numbers

Conversation

@Keavon

@Keavon Keavon commented Sep 21, 2026

Copy link
Copy Markdown
Member

No description provided.

@Keavon
Keavon requested a review from TrueDoctor as a code owner September 21, 2026 22:09

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 5 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread editor/src/messages/portfolio/document_migration.rs
Comment thread node-graph/interpreted-executor/src/node_registry.rs Outdated
Comment thread node-graph/interpreted-executor/src/dynamic_executor/test.rs Outdated
…d Is Nonzero nodes, and rename As f64 to As Number
@Keavon
Keavon force-pushed the booleans-as-numbers branch from 290a12a to c377350 Compare September 21, 2026 22:30
@Keavon
Keavon merged commit b22bbf6 into master Sep 21, 2026
11 checks passed
@Keavon
Keavon deleted the booleans-as-numbers branch September 21, 2026 22:42

This branch was successfully deployed

1 active deployment
graphite-dev (Preview) c3773501 Deployed Sep 21, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant