Repository navigation
proxyclient/run_guest: add --disable-node - #13
Open
hishamMounir wants to merge 1 commit into
Open
hishamMounir wants to merge 1 commit into
hishamMounir wants to merge 1 commit into
Conversation
ADevWithAnIdea
force-pushed
the
PR_sptm_hv
branch
from
November 3, 2026 07:56
8da6b14 to
8e5aee7
Compare
Member
|
Yo whats up Hisham, thanks for the PR! I'm not going to merge the SYS_APL_VM_TMR_FIQ_ENA_EL2 patch since we're not going to support any macOS version with that register locked, we're just going to wait for Apple to unlock it for us. The disable node patch looks good! Just rebase the patchset (I merged the HV patches) and I can merge! |
Deleting an ADT node to keep a guest away from a device is not always an option: SPTM reads /arm-io/ans.reg and nvme-queue-entries itself and panics before XNU runs if the node is gone. Prefix the node's compatible with "disabled," instead, which leaves the properties in place while keeping the guest's drivers off it. Assisted-By: LLM Signed-off-by: Hisham Alkhudrawi <hisham.ma.mohammed@gmail.com>
hishamMounir
force-pushed
the
j704/hv-t8142-timers
branch
from
November 4, 2026 17:18
6bdad67 to
7b7b8dd
Compare
hishamMounir
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased onto
mainnow that the HV series is merged, and trimmed to the onepatch you said you'd take. The
VM_TMR_FIQ_ENA_EL2timer-masking patch isdropped. Understood that you'll wait for Apple to unlock that register.
proxyclient/run_guest: add --disable-nodeDeleting an ADT node to keep a guest off a device is not always possible: SPTM
reads
/arm-io/ans.regandnvme-queue-entriesitself and panics before XNUruns if the node is gone. This prefixes the node's compatible with
disabled,instead, leaving the properties in place while keeping the guest's drivers off
it. That is how I keep a macOS guest off the internal SSD.
Testing
Used with this tree's SPTM emulator on J704 (M5, Mac17,2) with a 27.2 guest:
--disable-node /arm-io/ans, single-user mode, full CPU topology. The proxyruns and all secondaries start. On the rebased branch,
run_guest.pybyte-compiles and a full
m1n1.binbuilds and links.Clean room: no Apple binary was disassembled for this.
🤖 Generated with Claude Code