Push local changes to main#9
Merged
Merged
Conversation
…degen Only 3 consumers of this package exist today, all Go, already importing it directly — but the same class of drift this is meant to prevent has already happened once: hawk-sdk-go independently hand-rolled its own ToolResult with a field named tool_call_id, diverging from this repo's tool_use_id, because nothing checked for it. proto/hawk/contracts/v1/*.proto mirrors all 30 exported types across the 7 existing packages. Deliberately additive, not authoritative — the hand-written Go package is unchanged and stays the source of truth for Go consumers; regenerating it from proto risked breaking their JSON wire format for zero benefit (protoc-gen-go doesn't reliably preserve existing json: tags without extra glue). gen/go/ is its own nested Go module specifically so google.golang.org/protobuf never touches the root module's zero-dependency guarantee. Each non-obvious mapping decision (Severity/Risk keep Go's exact iota numeric values instead of the usual _UNSPECIFIED=0 sentinel, since map[Severity]int fields depend on that parity; time.Duration maps to int64 not google.protobuf.Duration, matching Go's actual JSON output) is documented inline in the .proto source. CI gains a proto job: buf lint, buf breaking against main (skips gracefully until this first lands, since main has no prior schema to compare against), and a buf generate smoke test. buf lint/breaking/generate were all run locally against a fresh buf install to confirm the schema is valid and codegen succeeds for Go, Python, and TypeScript before wiring any of this in. Also backfills the CHANGELOG, which had been stale since v0.1.1 — and fixes a real inaccuracy found while doing it: the v0.1.0 entry claimed sessions/ existed at initial release, but git history (git log --diff-filter=A) shows it was actually added in v0.1.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pushing local commits ahead of origin/main.