Skip to content

Sync stale submodule snapshot + gofumpt formatting#30

Merged
Patel230 merged 5 commits into
mainfrom
fix/hawk-external-yaad-20260708
Jul 8, 2026
Merged

Sync stale submodule snapshot + gofumpt formatting#30
Patel230 merged 5 commits into
mainfrom
fix/hawk-external-yaad-20260708

Conversation

@Patel230

@Patel230 Patel230 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

This branch carries commits that were sitting locally on this nested submodule checkout (used inside the hawk monorepo's `external/yaad`) but never pushed to any remote ref, plus a formatting fix:

  • chore: sync VERSION to 0.1.3 (match standalone)
  • refactor: consolidate version into root version.go with //go:embed VERSION
  • security: harden gosec findings (part of hawk-eco full-repo audit)
  • fix: gofumpt formatting in internal/server/rest_handlers.go (same fix as GrayCodeAI/yaad's main PR, applied here because this submodule snapshot predates it)

Pushing this unblocks hawk's CI `build-and-push` job, which fetches this submodule by exact commit SHA during `git submodule update`.

Patel230 added 5 commits July 7, 2026 10:17
- Integer-overflow guards on numeric conversions
- File/dir permission tightening (0600/0750)
- Path-traversal cleaning and error-return handling
- Narrow, justified #nosec annotations where risk is not applicable

Module now scans clean with gosec (0 issues).
…RSION

- Remove internal/version/ package (embedded stale co-located copy)
- Add root version.go with //go:embed VERSION as single source of truth
- Update rest handler to import root yaad package instead of internal/version
…d-20260708

# Conflicts:
#	engine/audit.go
#	internal/daemon/daemon.go
@Patel230
Patel230 merged commit 744f272 into main Jul 8, 2026
@Patel230
Patel230 deleted the fix/hawk-external-yaad-20260708 branch July 8, 2026 17:49
Patel230 added a commit that referenced this pull request Jul 11, 2026
* security: harden gosec findings (part of hawk-eco full-repo audit)

- Integer-overflow guards on numeric conversions
- File/dir permission tightening (0600/0750)
- Path-traversal cleaning and error-return handling
- Narrow, justified #nosec annotations where risk is not applicable

Module now scans clean with gosec (0 issues).

* refactor: consolidate version into root version.go with //go:embed VERSION

- Remove internal/version/ package (embedded stale co-located copy)
- Add root version.go with //go:embed VERSION as single source of truth
- Update rest handler to import root yaad package instead of internal/version

* chore: sync VERSION to 0.1.3 (match standalone)

* Apply gofumpt formatting to satisfy CI format check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant