fix(yaad): fix gRPC auth, HTTP status, privacy filter#36
Merged
Conversation
…vacy-filtered exports CRITICAL SECURITY FIXES: - Add WithAPIKey() for gRPC server authentication with constant-time token comparison - Check HTTP status codes in OpenAI embedding provider (prevents silent data corruption) - Apply privacy filter to exported memory content These changes address: - CRITICAL: Unauthenticated gRPC server exposure - HIGH: OpenAI embedding ignoring HTTP errors that could produce bogus data - HIGH: Memory exports containing raw secrets without privacy filtering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix gRPC authentication, HTTP status handling, and privacy filter.