Stop per-request log spam - #32
Draft
Guardian023 wants to merge 1 commit into
Draft
Conversation
Render200 fired on every response and "/updates endpoint hit" on every update, each ~55k lines in a session (110k of 127k log lines total). Route all the per-request/response endpoint logs through DebugLog (gated by settings.enableLogging) instead of the always-on Log. Real logs (startup, request exceptions, the /ws upgrade diagnostic) stay on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render200 (every response) and /updates endpoint hit (every update) were logging via the always-on Main.Log, producing ~110k of 127k lines in a single Player.log. Route the per-request/response endpoint logs through Main.DebugLog (gated behind settings.enableLogging) instead. Startup, request-exception, and the /ws upgrade diagnostic logs stay always-on. 11 call sites converted.