Conversation
YoniKiriaty
changed the title
YoniKiriaty
left a comment
YoniKiriaty
left a comment
There was a problem hiding this comment.
Thought this was good then I saw the App.tsx
…jects into playoff-schedule/init
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| throw new Error(`HTTP error, status: ${response.status}`); | ||
| } | ||
|
|
||
| return response.json() as Promise<T>; |
Check warning
Code scanning / ESLint
Disallow type assertions that narrow a type Warning
|
|
||
| export type MatchesSimpleType = typeof matchSimple._A; | ||
|
|
||
| export const urlMatches = (eventKey: string) => `/events/${eventKey}/matches`; |
Check warning
Code scanning / ESLint
Require explicit return and argument types on exported functions' and classes' public class methods Warning
| @@ -0,0 +1,4 @@ | |||
| // בס"ד | |||
|
|
|||
| export const urlRankings = (eventKey: string) => | |||
Check warning
Code scanning / ESLint
Require explicit return and argument types on exported functions' and classes' public class methods Warning
| const fullUrl = joinUrl(targetPath); | ||
| const response = await fetch(fullUrl); | ||
| if (response.ok) { | ||
| return (await response.json()) as T; |
Check warning
Code scanning / ESLint
Disallow type assertions that narrow a type Warning
| @@ -0,0 +1,2 @@ | |||
| // בס"ד | |||
| export const urlRankings = (eventKey: string) => `/events/${eventKey}/rankings`; | |||
Check warning
Code scanning / ESLint
Require explicit return and argument types on exported functions' and classes' public class methods Warning
| app.use(express.urlencoded({ limit: "10mb", extended: true })); | ||
|
|
||
| app.use( | ||
| cors({ |
Check warning
Code scanning / ESLint
Disallow calling a value with type `any` Warning
|
|
||
| const queryClient = new QueryClient(); | ||
|
|
||
| createRoot(document.getElementById("root")!).render( |
Check warning
Code scanning / ESLint
Disallow non-null assertions using the `!` postfix operator Warning
| return null; | ||
| } | ||
| return { | ||
| opponentAlliance: opponentData.alliance, |
Check warning
Code scanning / ESLint
Disallow assigning a value with type `any` to variables and properties Warning
| return { | ||
| opponentAlliance: opponentData.alliance, | ||
| opponentTeams: opponentData.teams, | ||
| ourAlliance: ourAllianceEntry.alliance, |
Check warning
Code scanning / ESLint
Disallow assigning a value with type `any` to variables and properties Warning
| ): OpponentInfo | null => { | ||
| const potentialNextOpponents = nextMatchAlliances | ||
| .map(({ alliance, teams }) => ({ | ||
| alliance, |
Check warning
Code scanning / ESLint
Disallow assigning a value with type `any` to variables and properties Warning
| if (potentialNextOpponents.length === potentialOpponentsFirst) { | ||
| const [opponent] = potentialNextOpponents; | ||
| return { | ||
| opponentAlliance: opponent.alliance, |
Check warning
Code scanning / ESLint
Disallow assigning a value with type `any` to variables and properties Warning
| return []; | ||
| } | ||
|
|
||
| if (feedingMatch.winning_alliance) { |
| }; | ||
| } | ||
|
|
||
| if (target === "finals") { |
There was a problem hiding this comment.
split the insides of this if into a getNextFinal or smthing
There was a problem hiding this comment.
merge master and use the one in maaster
5 participants
the project makes a schedule for playoff and events that happened and will happen