Skip to content

A few account bug fixes#1069

Merged
GregHib merged 8 commits into
mainfrom
bug-fix-list
Jul 10, 2026
Merged

A few account bug fixes#1069
GregHib merged 8 commits into
mainfrom
bug-fix-list

Fix account definitions incorrectly using account name instead of dis…

a150436
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 10, 2026 in 1s

43.18% (+0.00%) compared to 20b7ee3

View this Pull Request on Codecov

43.18% (+0.00%) compared to 20b7ee3

Details

Codecov Report

❌ Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.18%. Comparing base (20b7ee3) to head (a150436).

Files with missing lines Patch % Lines
...oidps/engine/data/definition/AccountDefinitions.kt 72.72% 3 Missing ⚠️
...rld/gregs/voidps/engine/client/EncodeExtensions.kt 0.00% 0 Missing and 1 partial ⚠️
.../gregs/voidps/engine/client/PlayerAccountLoader.kt 50.00% 1 Missing ⚠️
.../main/kotlin/content/entity/player/Introduction.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...orld/gregs/voidps/network/login/PasswordManager.kt 81.81% <100.00%> (+1.81%) ⬆️
...rld/gregs/voidps/engine/client/EncodeExtensions.kt 7.61% <0.00%> (ø)
.../gregs/voidps/engine/client/PlayerAccountLoader.kt 64.00% <50.00%> (-1.31%) ⬇️
.../main/kotlin/content/entity/player/Introduction.kt 14.28% <0.00%> (-0.35%) ⬇️
...oidps/engine/data/definition/AccountDefinitions.kt 58.57% <72.72%> (+3.34%) ⬆️

... and 1 file with indirect coverage changes

@@            Coverage Diff            @@
##               main    #1069   +/-   ##
=========================================
  Coverage     43.17%   43.18%           
- Complexity     8958     8964    +6     
=========================================
  Files          1817     1817           
  Lines         78390    78397    +7     
  Branches      13167    13169    +2     
=========================================
+ Hits          33848    33855    +7     
- Misses        39654    39655    +1     
+ Partials       4888     4887    -1     
Components Coverage Δ
Content 43.24% <0.00%> (-0.01%) ⬇️
Engine 45.80% <64.28%> (+0.01%) ⬆️
Network 71.40% <100.00%> (+0.06%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.