Use hours as unit when finding center to avoid rounding issues - #161
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review comments; the calculation preserves time values correctly.
Pull request overview
Fixes time-window midpoint calculations to prevent date/time shifts caused by fractional-day rounding.
Changes:
- Adds the half-window in hours.
- Preserves fractional-day precision.
File summaries
| File | Description |
|---|---|
PQBrowser/Scripts/TSX/Components/EventSearch/TimeWindowUtils.tsx |
Fixes midpoint calculation precision. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
elwills
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a time-filter issue where changing the start date could shift both time values by 12 hours. The midpoint calculation now adds the half-window in hours to avoid Moment rounding fractional days.
Verified that repeated date changes preserve the end time/start time.