DockerBuilds - #170
DockerBuilds#170prestoncraw wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The workspace path conversion prevents the remote Docker build from running.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
Re-enables PQBrowser Docker image builds through the CI server’s WSL Docker instance over SSH.
Changes:
- Restores Docker publishing and image tagging.
- Converts the Jenkins workspace to a WSL path.
- Propagates remote build failures.
| File | Description |
|---|---|
Jenkinsfile |
Implements Docker publishing and SSH-based WSL builds. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| ]) { | ||
| powershell ''' | ||
| $key = 'C:\\ProgramData\\Jenkins\\.ssh\\wsl_docker' | ||
| $wslPath = '/mnt/' + $env:WORKSPACE.Substring(0, 1).ToLowerInvariant() + $env:WORKSPACE.Substring(2).Replace('\\', '/') |
There was a problem hiding this comment.
Not an issue. This is a Groovy ''' string, which still processes backslash escapes (it only disables $ interpolation). So the Jenkinsfile source:
.Replace('\\', '/')
reaches PowerShell as:
.Replace('\', '/')
which is a single literal backslash, and String.Replace is not regex. Result: /mnt/c/Jenkins/workspace/.... The existing dotnet publish line in this file relies on the same escaping.
Re-enable the PQBrowser Docker stage and run image builds over SSH to the CI server's WSL Docker instance. Convert the Jenkins workspace path to its Linux mount path and propagate build failures.