WidgetImprovements - #84
Merged
Merged
Conversation
- Time unit selector shows the unit auto resolves to (e.g. "seconds (auto)"), matching the axis unit selectors - Tooltip and Tooltip w/ Delta show the time unit under the truncated value and the full timestamp below it - Centralize the auto ms/s rule in getAutoTimeUnit/resolveTimeUnit and use it in the x-axis ticks, axis label, time deltas, and selector - Remove unused time variables from AccumulatedPoints
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
One or more issues must be addressed before approval.
Review effort: Lite
Findings: None
What changed in this PR
Improves time-unit display and timestamp visibility across plot settings and tooltip widgets, while centralizing automatic time-unit resolution.
Changes:
- Adds resolved auto-unit labels to selectors, axes, and tooltips.
- Adds UTC full timestamps to tooltips.
- Refactors shared time-unit formatting logic and removes unused code.
| File | Description |
|---|---|
| src/OpenSEE/wwwroot/Scripts/TSX/Widgets/TooltipWithDelta.tsx | Updated as part of this pull request. |
| src/OpenSEE/wwwroot/Scripts/TSX/Widgets/Tooltip.tsx | Updated as part of this pull request. |
| src/OpenSEE/wwwroot/Scripts/TSX/Widgets/PlotSettings/TimeUnitSelector.tsx | Updated as part of this pull request. |
| src/OpenSEE/wwwroot/Scripts/TSX/Widgets/PlotSettings/SettingWindow.tsx | Updated as part of this pull request. |
| src/OpenSEE/wwwroot/Scripts/TSX/Widgets/AccumulatedPoints.tsx | Updated as part of this pull request. |
| src/OpenSEE/wwwroot/Scripts/TSX/Graphs/Utils/Utilities.tsx | Updated as part of this pull request. |
| src/OpenSEE/wwwroot/Scripts/TSX/Graphs/LineChart/Renderers/XAxes.ts | Updated as part of this pull request. |
| src/OpenSEE/package-lock.json | Updated as part of this pull request. |
Files not reviewed (1)
- src/OpenSEE/package-lock.json: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
elwills
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves how time units and timestamps are shown in the plot settings and tooltip widgets, and centralizes the "auto" time unit logic that was duplicated across the app.
Changes
Time unit selector
seconds (auto)), consistent with the voltage/current unit selectors.Tooltip and Tooltip w/ Delta
YYYY-MM-DD HH:mm:ss.SSS) is shown below it, so the exact date/time of the point is visible. It is formatted with.utc()like the other full timestamps in the app, so it shows the meter's recorded time rather than shifting to the viewer's time zone.Refactor
getAutoTimeUnit/resolveTimeUnitinUtilities.tsxand is used by the x-axis ticks, x-axis label,formatTimeDelta, and the time unit selector. Output is unchanged for every valid time unit setting.AccumulatedPoints.